From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] Add call volume support for hfpmodem
Date: Wed, 11 Nov 2009 00:41:35 -0600 [thread overview]
Message-ID: <200911110041.35538.denkenz@gmail.com> (raw)
In-Reply-To: <0463F45F3606F4428ED35AC8C709F92E089CA6A25D@pdsmsx502.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
Hi Zhenhua,
> > Make sure to ofono_call_volume_set_data(cv, NULL) here.
>
> I don't see ofono_call_volume_set_data(cv, NULL) or
> ofono_voicecall_set_data(vc, NULL) from atmodem either. Anyway, I add the
> code in hfp_call_volume_remove.
>
Then that needs to be fixed. Care to send a patch?
In general you should set_data to NULL before freeing it.
Regards,
-Denis
prev parent reply other threads:[~2009-11-11 6:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 13:32 [PATCH 2/2] Add call volume support for hfpmodem Zhenhua Zhang
2009-11-11 5:52 ` Denis Kenzior
2009-11-11 6:31 ` Zhang, Zhenhua
2009-11-11 6:41 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911110041.35538.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox