From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/2] Fix: Username and Password must be set after context is created.
Date: Mon, 01 Feb 2010 13:20:03 -0600 [thread overview]
Message-ID: <201002011320.04073.denkenz@gmail.com> (raw)
In-Reply-To: <1265051445.31341.54.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
Hi Marcel,
> > > And we might wanna check if MBM cards behave similar and ensure that
> > > STE and MBM cards use a similar code flow.
> >
> > When testing this EIAAUW fails if there are no prior PDP context on the
> > modem. Most likely this is the case with the MBM module as well, but I
> > have not tested this.
>
> Then we have to do that in the callback in an extra step. I don't really
> like it, but seems the way to go. Please send a patch that also changes
> this for MBM devices. We really wanna keep these in sync.
Actually the easiest way to do this is simply queue the EIAAUW after the
CGDCONT in activate_context. If CGDCONT fails then EIAAUW won't have any
effect anyway (but will get executed nevertheless). This is better than
worrying about strduping username/password and freeing it in all possible code
paths.
Regards,
-Denis
>
> Regards
>
> Marcel
>
next prev parent reply other threads:[~2010-02-01 19:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 15:50 [PATCH 1/2] Fix: Username and Password must be set after context is created sjur.brandeland
2010-02-01 15:50 ` [PATCH 2/2] Fix: Check if interface exists before creating it sjur.brandeland
2010-02-01 16:03 ` Marcel Holtmann
2010-02-01 20:40 ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-02-01 21:40 ` Marcel Holtmann
2010-02-01 16:09 ` [PATCH 1/2] Fix: Username and Password must be set after context is created Marcel Holtmann
2010-02-01 17:23 ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-02-01 19:10 ` Marcel Holtmann
2010-02-01 19:20 ` Denis Kenzior [this message]
2010-02-01 21:41 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002011320.04073.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox