From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Fix change state immediately when meet the slash
Date: Tue, 02 Feb 2010 11:47:22 -0600 [thread overview]
Message-ID: <201002021147.22460.denkenz@gmail.com> (raw)
In-Reply-To: <1265117002-11006-1-git-send-email-zhenhua.zhang@intel.com>
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
Hi Zhenhua,
> According to V.250 spec section 5.2.4 Repeating a command line, if
> the prefix "A/" or "a/" is received, we should execute the last
> command immediately. No need to meet \r.
Yes you're right.
> @@ -214,22 +213,14 @@ static enum ParserResult server_feed(GAtServer
> *server, i += 1;
> res = PARSER_RESULT_GARBAGE;
> goto out;
> - } else if (byte == '/')
> - server->parser_state = PARSER_STATE_SLASH;
> - else if (byte == 'T' || byte == 't')
> + } else if (byte == '/') {
> server->parser_state = PARSER_STATE_COMMAND;
I changed this to PARSER_STATE_IDLE and applied the patch.
Regards,
-Denis
prev parent reply other threads:[~2010-02-02 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 13:23 [PATCH] Fix change state immediately when meet the slash Zhenhua Zhang
2010-02-02 17:47 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002021147.22460.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox