From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 4/4] Fix server only return the final parser result
Date: Wed, 03 Mar 2010 13:09:44 -0600 [thread overview]
Message-ID: <201003031309.44884.denkenz@gmail.com> (raw)
In-Reply-To: <1267525299-5740-4-git-send-email-zhenhua.zhang@intel.com>
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
Hi Zhenhua,
> In case we meet compound commands in single line, AtServer should
> only return the parser result of last command according to spec.
> So we return the parser result in the parse iteration.
So I agree that we need to do this, but I disagree with the approach. I
suggest we let g_at_server_send_result take care of this. This will make
extended errors much easier to handle.
Regards,
-Denis
next prev parent reply other threads:[~2010-03-03 19:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 10:21 [PATCH 1/4] Add command echo back if ATE=1 Zhenhua Zhang
2010-03-02 10:21 ` [PATCH 2/4] Fix remove wrong extended prefix Zhenhua Zhang
2010-03-02 10:21 ` [PATCH 3/4] Update rename result to state Zhenhua Zhang
2010-03-02 10:21 ` [PATCH 4/4] Fix server only return the final parser result Zhenhua Zhang
2010-03-03 19:09 ` Denis Kenzior [this message]
2010-03-04 1:31 ` Zhenhua Zhang
2010-03-03 19:07 ` [PATCH 3/4] Update rename result to state Denis Kenzior
2010-03-03 19:17 ` [PATCH 2/4] Fix remove wrong extended prefix Denis Kenzior
2010-03-04 1:38 ` Zhenhua Zhang
2010-03-03 19:02 ` [PATCH 1/4] Add command echo back if ATE=1 Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003031309.44884.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox