From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/4] Handle the conversion failure when parsing item
Date: Tue, 16 Mar 2010 14:29:49 -0600 [thread overview]
Message-ID: <201003161529.49624.denkenz@gmail.com> (raw)
In-Reply-To: <1268733700-30154-2-git-send-email-yang.gu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 265 bytes --]
Hi Yang,
> - item->text = sim_string_to_utf8(data+1, len-1);
> + utf8 = sim_string_to_utf8(data+1, len-1);
I applied the patch and fixed up the arithmetic operator style issue. Please
make sure you follow this convention from now on.
Regards,
-Denis
next prev parent reply other threads:[~2010-03-16 20:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 10:01 [PATCH 1/4] Fix the structure of stk_subaddress Yang Gu
2010-03-16 10:01 ` [PATCH 2/4] Handle the conversion failure when parsing item Yang Gu
2010-03-16 10:01 ` [PATCH 3/4] Add parser for file list objects Yang Gu
2010-03-16 10:01 ` [PATCH 4/4] Add parser for location information objects Yang Gu
2010-03-16 18:46 ` Marcel Holtmann
2010-03-16 18:44 ` [PATCH 3/4] Add parser for file list objects Marcel Holtmann
2010-03-16 20:01 ` Denis Kenzior
2010-03-16 18:36 ` [PATCH 2/4] Handle the conversion failure when parsing item Marcel Holtmann
2010-03-16 20:27 ` Denis Kenzior
2010-03-17 4:40 ` Marcel Holtmann
2010-03-16 20:29 ` Denis Kenzior [this message]
2010-03-17 3:33 ` Gu, Yang
2010-03-17 4:44 ` Marcel Holtmann
2010-03-16 20:28 ` [PATCH 1/4] Fix the structure of stk_subaddress Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003161529.49624.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox