Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 01/11] Rename g_at_server_send_result
Date: Wed, 17 Mar 2010 12:24:58 -0600	[thread overview]
Message-ID: <201003171324.58424.denkenz@gmail.com> (raw)
In-Reply-To: <4BA0E979.1030004@intel.com>

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

Hi Zhenhua,

> Sorry, I forgot the first patch. Please review the first patch as
> attached. Otherwise, these patches could not be applied.

Please get rid of this patch and rebase the rest appropriately.  I mentioned 
in the other reply, there's no sense to remove a bunch of code only to add 
nearly the same back in.

Regards,
-Denis

      reply	other threads:[~2010-03-17 18:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-17 14:30 [PATCH 01/11] Rename g_at_server_send_result Zhenhua Zhang
2010-03-17 14:30 ` [PATCH 02/11] Add framework of server parser Zhenhua Zhang
2010-03-17 14:30   ` [PATCH 03/11] Add basic command parsing Zhenhua Zhang
2010-03-17 14:30     ` [PATCH 04/11] Add extended " Zhenhua Zhang
2010-03-17 14:30       ` [PATCH 05/11] Add server at command data structure Zhenhua Zhang
2010-03-17 14:30         ` [PATCH 06/11] Add notify at command callback Zhenhua Zhang
2010-03-17 14:30           ` [PATCH 07/11] Add g_at_server_register and unregister callback Zhenhua Zhang
2010-03-17 14:30             ` [PATCH 08/11] Add G_AT_SERVER_RESULT_EXT_ERROR Zhenhua Zhang
2010-03-17 14:30               ` [PATCH 09/11] Fix do not emit error if extended error has emitted Zhenhua Zhang
2010-03-17 14:30                 ` [PATCH 10/11] Refactor g_at_server_send_final Zhenhua Zhang
2010-03-17 14:30                   ` [PATCH 11/11] Add utilities to send server response Zhenhua Zhang
2010-03-17 18:23           ` [PATCH 06/11] Add notify at command callback Denis Kenzior
2010-03-17 18:02     ` [PATCH 03/11] Add basic command parsing Denis Kenzior
2010-03-17 17:55   ` [PATCH 02/11] Add framework of server parser Denis Kenzior
2010-03-17 14:38 ` [PATCH 01/11] Rename g_at_server_send_result Zhenhua Zhang
2010-03-17 18:24   ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003171324.58424.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox