Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/7] Return newly-queried barring status.
Date: Thu, 18 Mar 2010 11:39:35 -0500	[thread overview]
Message-ID: <201003181139.35438.denkenz@gmail.com> (raw)
In-Reply-To: <1268923471-29059-2-git-send-email-ppessi@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

Hi Pekka,

>  	for (i = cb->query_start; i <= cb->query_end; i++) {
>  		cb->cur_locks[i] = cb->new_locks[i];
> -		cb->new_locks[i] = 0;
>  	}

Can you also ensure that if a loop / if statement no longer requires braces 
that your patch also takes care of that too?  I fixed it up for you afterward.

Patch has been applied, thanks.

Regards,
-Denis

Regards,
-Denis

  parent reply	other threads:[~2010-03-18 16:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18 14:44 [PATCH 1/7] Barring services can only be activated/deactivated ppessi
2010-03-18 14:44 ` [PATCH 2/7] Return newly-queried barring status ppessi
2010-03-18 14:44   ` [PATCH 3/7] Number of barring services is constant ppessi
2010-03-18 14:44     ` [PATCH 4/7] Network password has exactly 4 digits ppessi
2010-03-18 14:44       ` [PATCH 5/7] Interrogation of a barring does not require password ppessi
2010-03-18 14:44         ` [PATCH 6/7] Added call-barring-api.txt ppessi
2010-03-18 14:44           ` [PATCH 7/7] Fix: isimodem handling of call barring services ppessi
2010-03-18 16:51             ` Denis Kenzior
2010-03-18 17:38               ` Pekka Pessi
2010-03-18 17:50                 ` Denis Kenzior
2010-03-18 16:46           ` [PATCH 6/7] Added call-barring-api.txt Denis Kenzior
2010-03-18 16:44         ` [PATCH 5/7] Interrogation of a barring does not require password Denis Kenzior
2010-03-18 16:43       ` [PATCH 4/7] Network password has exactly 4 digits Denis Kenzior
2010-03-19 14:36         ` Pekka Pessi
2010-03-18 16:40     ` [PATCH 3/7] Number of barring services is constant Denis Kenzior
2010-03-18 16:39   ` Denis Kenzior [this message]
2010-03-18 16:11 ` [PATCH 1/7] Barring services can only be activated/deactivated Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003181139.35438.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox