From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: calypso does not power up from 0.17
Date: Wed, 14 Apr 2010 05:43:05 -0500 [thread overview]
Message-ID: <201004140543.06250.denkenz@gmail.com> (raw)
In-Reply-To: <t2g359c5481004140152gdc106afcpfaaf00df4c75e9a@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]
Hi Niko,
> Hi!
>
> 0.16 is the last release that works (well) on the openmoko freerunner
> while from 0.17 to 0.20 I have:
>
> root(a)om-gta02 ~ $ dbus-send --system --dest=org.ofono --print-reply
> /freerunner org.ofono.Modem.SetProperty string:Powered
> variant:boolean:true
> Error org.ofono.Error.Timedout: Operation failure due to timeout
>
> I'm sorry I do not have much time in this period to dig deeply, anyway
> I found the commit that introduced the problem with git bisect.
I have a hunch that the GAtMux code might need some love. Can you try the
following patch?
diff --git a/gatchat/gatmux.c b/gatchat/gatmux.c
index b70f6a0..139edd2 100644
--- a/gatchat/gatmux.c
+++ b/gatchat/gatmux.c
@@ -433,6 +433,9 @@ static GIOStatus channel_read(GIOChannel *channel, gchar
*buf, gsize count,
*bytes_read = ring_buffer_read(mux_channel->buffer, buf, avail);
+ if (*bytes_read == 0)
+ return G_IO_STATUS_AGAIN;
+
return G_IO_STATUS_NORMAL;
}
Regards,
-Denis
next prev parent reply other threads:[~2010-04-14 10:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 8:52 calypso does not power up from 0.17 Nicola Mfb
2010-04-14 9:17 ` Zhenhua Zhang
2010-04-14 9:57 ` Dario
2010-04-14 10:43 ` Denis Kenzior [this message]
2010-04-14 11:45 ` Nicola Mfb
2010-04-14 15:41 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004140543.06250.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox