Re: [PATCH 7/8] Add AT driver for STK atom.

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

Hi Andrew,

> ---
>  Makefile.am               |    1 +
>  drivers/atmodem/atmodem.c |    2 +
>  drivers/atmodem/atmodem.h |    3 +
>  drivers/atmodem/stk.c     |  258
>  +++++++++++++++++++++++++++++++++++++++++++++ plugins/atgen.c           | 
>    2 +
>  plugins/phonesim.c        |    3 +
>  6 files changed, 269 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/atmodem/stk.c

I did apply the patch, however I have a question:

The terminal response goes something like this:

> +
> +	len = sprintf(buf, "AT+CSIM=%i,A0140000%02hhX",
> +			10 + length * 2, length);
> +
> +	for (; length; length--)
> +		len += sprintf(buf + len, "%02hhX", *value++);
> +

In the new stk envelope code it goes something like this:

> 
> +	len = sprintf(buf, "AT+CSIM=%i,A0C20000%02hhX",
> +			12 + length * 2, length);
> +
> +	for (; length; length--)
> +		len += sprintf(buf + len, "%02hhX", *command++);
> +
> +	len += sprintf(buf + len, "FF");

What is the point of this last 'FF'?  The code removed from the sim atom 
driver doesn't have it either...

Regards,
-Denis