From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Added Wavecom modem plugin.
Date: Tue, 20 Apr 2010 12:03:10 -0500 [thread overview]
Message-ID: <201004201203.11179.denkenz@gmail.com> (raw)
In-Reply-To: <1271722185-1321-1-git-send-email-matgnt@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
Hi Matthias,
> The Wavecom WMP100 assumes CPIN to be the final response, therefore some
> special handling is neccessary (see
> 6d28f82dc1ccb3de3a028a88eafb96fb001c7e61). Now the vendor id
> OFONO_VENDOR_WAVECOM is passed with all "*create" functions.
I massaged the commit message and pushed the patch. I did make two small
changes afterward:
> + if (!channel) {
> + return -EIO;
> + }
Coding style requires this to be without braces (all single statement blocks
if/while/for should not have braces)
> +
> + /* Could not figure out whether it is fully compliant or not */
> + syntax = g_at_syntax_new_gsm_permissive();
> + //syntax = g_at_syntax_new_gsmv1();
Commented out code is not a good idea, if you're not sure about something
reflect it in the comment.
Regards,
-Denis
prev parent reply other threads:[~2010-04-20 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 19:34 [PATCH] Added Wavecom modem plugin Matthias
2010-04-19 21:29 ` Denis Kenzior
2010-04-20 0:09 ` Matthias =?unknown-8bit?q?G=C3=BCnther?=
2010-04-20 17:03 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004201203.11179.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox