From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] usbpnmodem: configure usbpn interfaces automatically
Date: Thu, 22 Apr 2010 17:51:24 -0500 [thread overview]
Message-ID: <201004221751.25146.denkenz@gmail.com> (raw)
In-Reply-To: <1271935632-8567-1-git-send-email-Pekka.Pessi@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
Hi Pekka,
> ---
> drivers/isimodem/isimodem.c | 2 +-
> gisi/netlink.c | 242
> ++++++++++++++++++++++++++++++++++++++++--- gisi/netlink.h |
> 11 ++-
> plugins/usbpnmodem.c | 10 ++-
> 4 files changed, 244 insertions(+), 21 deletions(-)
>
>
We're quite serious about coding style here:
WARNING: line over 80 characters
#156: FILE: gisi/netlink.c:239:
+ g_critical("Netlink error: %s", strerror(-err->error));
ERROR: code indent should use tabs where possible
#204: FILE: gisi/netlink.c:367:
+ for (; NLMSG_OK(nlh, (size_t)ret); nlh = NLMSG_NEXT(nlh, ret)) {$
WARNING: line over 80 characters
#210: FILE: gisi/netlink.c:373:
+ struct nlmsgerr *err = (struct nlmsgerr *)NLMSG_DATA(nlh);
ERROR: need consistent spacing around '|' (ctx:VxW)
#306: FILE: gisi/netlink.c:469:
+ | NLM_F_CREATE| NLM_F_APPEND,
Regards,
-Denis
next prev parent reply other threads:[~2010-04-22 22:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 11:27 [PATCH] usbpnmodem: configure usbpn interfaces automatically Pekka Pessi
2010-04-22 22:51 ` Denis Kenzior [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-04-23 15:05 Pekka Pessi
2010-04-23 18:00 ` Denis Kenzior
2010-04-28 13:03 ` Pekka Pessi
2010-04-28 13:10 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-04-28 14:15 ` Pekka Pessi
2010-04-28 16:08 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-05-04 13:55 ` Pekka Pessi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004221751.25146.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox