From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 3/6] stkutil: Use struct to represent frame id
Date: Mon, 26 Apr 2010 11:41:35 -0500 [thread overview]
Message-ID: <201004261141.35220.denkenz@gmail.com> (raw)
In-Reply-To: <1272277766-25432-3-git-send-email-yang.gu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
Hi Yang,
> Use a field has_id to indicate if we have frame id or not. Originally we
> use 0xFF to indicate we don't have frame id. But in that way, we have to
> initialize each test case of proactive command when it doesn't have this
> comprehension tlv to be 0xFF. To use has_id will save this effort, and
> keep consistency with other implementations.
> ---
> src/stkutil.c | 13 +++----------
> src/stkutil.h | 12 +++++++++---
> 2 files changed, 12 insertions(+), 13 deletions(-)
I'm fine with this one, can you rework #2 and resubmit along with this one?
Regards,
-Denis
next prev parent reply other threads:[~2010-04-26 16:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 10:29 [PATCH 1/6] stkutil: Fix the assignment to minimum set Yang Gu
2010-04-26 10:29 ` [PATCH 2/6] stkutil: Move advance of ctlv to decicated proactive commands parser Yang Gu
2010-04-26 14:53 ` Andrzej Zaborowski
2010-04-26 15:39 ` Denis Kenzior
2010-04-27 9:42 ` Gu, Yang
2010-04-26 10:29 ` [PATCH 3/6] stkutil: Use struct to represent frame id Yang Gu
2010-04-26 16:41 ` Denis Kenzior [this message]
2010-04-26 10:29 ` [PATCH 4/6] test-stkutil: Refactor the implementation to test display text Yang Gu
2010-04-26 10:29 ` [PATCH 5/6] stkutil: Add parser for more time proactive commands Yang Gu
2010-04-26 10:29 ` [PATCH 6/6] test-stkutil: Add unit test for more time parser Yang Gu
2010-04-26 16:32 ` [PATCH 1/6] stkutil: Fix the assignment to minimum set Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004261141.35220.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox