Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] ppp: use default ACCM when sending LCP codes 1-7
Date: Mon, 26 Apr 2010 15:32:08 -0500	[thread overview]
Message-ID: <201004261532.08812.denkenz@gmail.com> (raw)
In-Reply-To: <1272307476-22148-1-git-send-email-kristen@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

Hi Kristen,

> According to the spec, you must transmit all Link Configuration,
> Termination, and Code-Reject packets as if no options had been
> negotiated.  This requires that when encoding we use the
> default ACCM of 0xffffffff when sending these types of packets.
> ---
>  gatchat/gatppp.c |   10 ++++++++++
>  gatchat/ppp_cp.c |    8 ++++++++
>  gatchat/ppp_cp.h |    2 ++
>  3 files changed, 20 insertions(+), 0 deletions(-)
> 

This patch has been applied, thanks.

Regards,
-Denis

      reply	other threads:[~2010-04-26 20:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-26 18:44 [PATCH] ppp: use default ACCM when sending LCP codes 1-7 Kristen Carlson Accardi
2010-04-26 20:32 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004261532.08812.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox