From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/7] stkutil: Move advance of ctlv to parse_dataobj
Date: Tue, 27 Apr 2010 09:36:21 -0500 [thread overview]
Message-ID: <201004270936.22558.denkenz@gmail.com> (raw)
In-Reply-To: <1272361632-21352-1-git-send-email-yang.gu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
Hi Yang,
> Not all the proactive commands have comprehension tlv other than command
> details and device identities. So the appropriate code should be moved to
> parse_dataobj() from stk_command_new_from_pdu().
> ---
> src/stkutil.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
All 7 patches have been applied, thanks. Can you make sure your commit
headers are less than 50 characters long and your commit description is less
than 72 characters long?
Regards,
-Denis
prev parent reply other threads:[~2010-04-27 14:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 9:47 [PATCH 1/7] stkutil: Move advance of ctlv to parse_dataobj Yang Gu
2010-04-27 9:47 ` [PATCH 2/7] stkutil: Use struct to represent frame id Yang Gu
2010-04-27 9:47 ` [PATCH 3/7] test-stkutil: Refactor the implementation to test display text Yang Gu
2010-04-27 9:47 ` [PATCH 4/7] stkutil: Add parser for more time proactive commands Yang Gu
2010-04-27 9:47 ` [PATCH 5/7] test-stkutil: Add unit test for more time parser Yang Gu
2010-04-27 9:47 ` [PATCH 6/7] stkutil: Change some dataobj parser to use char * instead of char ** Yang Gu
2010-04-27 9:47 ` [PATCH 7/7] stkutil: Make get inkey parser use its own struct Yang Gu
2010-04-27 14:36 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004270936.22558.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox