Re: [PATCH] Add send_method_call to g_dbus

[Johan Hedberg <johan.hedberg@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

Hi,

On Tue, Apr 27, 2010, Marcel Holtmann wrote:
> > +gboolean g_dbus_send_method_call(DBusConnection *connection, const char *dest,
> > +				const char *path, const char *interface,
> > +				const char *method, int type, ...);
> > +gboolean g_dbus_send_method_call_with_reply(DBusConnection *connection,
> > +				const char *dest, const char *path,
> > +				const char *interface, const char *method,
> > +				DBusPendingCallNotifyFunction cb,
> > +				void *user_data, DBusFreeFunction free_func,
> > +				int timeout, int type, ...);
> 
> Is there any real reason to export send_method_call and
> create_method_call? What are these good for and what are your expected
> users of these?
> 
> I think that a g_dbus_method_call which is always async and take a
> pending call notifier is just enough.

In many cases you also want/need the ability to cancel the method call
before a reply has been received. If the DBusPendingCall object isn't
exposed to the caller then it seems canceling wouldn't be possible with
this API.

Johan