From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] ppp: transition phase to DEAD when lcp finishes
Date: Mon, 10 May 2010 12:19:48 -0500 [thread overview]
Message-ID: <201005101219.48429.denkenz@gmail.com> (raw)
In-Reply-To: <20100510100840.4f495736@kcaccard-MOBL3>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
Hi Kristen,
> On Mon, 10 May 2010 09:21:37 -0500
>
> Denis Kenzior <denkenz@gmail.com> wrote:
> > Hi Kristen,
> >
> > > change the state to DEAD when lcp finishes. This prevents us from
> > > calling our disconnect function again if we are already dead.
> >
> > I'm curious under what circumstances tlf gets called on LCP when we're
> > already down?
>
> A timeout after sending a terminate ack causes a tlf and switches us
> to the STOPPED state. disconnect function is called at tlf, and
> disconnect reason correctly set. Then, our read watcher is destroyed and
> we signal down (transitions us to state STARTING) and close (calls tlf
> and transitions us to INITIAL). Disconnect function is called with
> disconnect reason set to link dead.
>
Ah yes, the silly Huawei hardware. Sounds like we should ignore GAtIO
disconnects when we're already in PPP_DEAD phase.
Regards,
-Denis
prev parent reply other threads:[~2010-05-10 17:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 22:23 [PATCH] ppp: transition phase to DEAD when lcp finishes Kristen Carlson Accardi
2010-05-10 14:21 ` Denis Kenzior
2010-05-10 17:08 ` Kristen Carlson Accardi
2010-05-10 17:19 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005101219.48429.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox