From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] ppp: set address and control field
Date: Mon, 10 May 2010 16:40:57 -0500 [thread overview]
Message-ID: <201005101640.57357.denkenz@gmail.com> (raw)
In-Reply-To: <1273521997-7356-1-git-send-email-kristen@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
Hi Kristen,
> Before sending to hdlc, set the address and control field.
> Fix hardcode of ppp header size.
Patch has been applied with one minor modification:
> +#define PPP_ADDR_FIELD 0xff
> +#define PPP_CTRL 0x03
These really should be private.
> @@ -83,7 +83,7 @@ static void chap_process_challenge(struct ppp_chap *chap,
> const guint8 *packet) */
> digest_len = g_checksum_type_get_length(chap->method);
> response_length = digest_len + sizeof(*header) + 1;
> - ppp_packet = g_try_malloc0(response_length + 2);
> + ppp_packet = g_try_malloc0(response_length + sizeof(struct ppp_header));
> if (!ppp_packet)
> goto challenge_out;
Can we make this function use pppcp_packet_new or similar?
Regards,
-Denis
prev parent reply other threads:[~2010-05-10 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 20:06 [PATCH] ppp: set address and control field Kristen Carlson Accardi
2010-05-10 21:40 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005101640.57357.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox