From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v4 2/3] Move report_signal_strength to atutil
Date: Wed, 19 May 2010 19:36:23 -0500 [thread overview]
Message-ID: <201005191936.23348.denkenz@gmail.com> (raw)
In-Reply-To: <20100520080414.17288.40729.stgit@potku.valot.fi>
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
Hi Kalle,
>
> static void csq_notify(GAtResult *result, gpointer user_data)
> @@ -490,7 +489,8 @@ static void csq_notify(GAtResult *result, gpointer
> user_data) if (!g_at_result_iter_next_number(&iter, &strength))
> return;
>
> - report_signal_strength(netreg, strength);
> + ofono_netreg_strength_notify(netreg,
> + at_util_convert_signal_strength(strength));
> }
How about fixing all other instances of report_signal_strength and removing it
from this file as well? ;)
Regards,
-Denis
next prev parent reply other threads:[~2010-05-20 0:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 8:04 [PATCH v4 0/3] Huawei GPRS support Kalle Valo
2010-05-20 8:04 ` [PATCH v4 1/3] huawei: detect possible secondary device Kalle Valo
2010-05-20 0:34 ` Denis Kenzior
2010-05-20 10:46 ` Kalle Valo
2010-05-20 8:04 ` [PATCH v4 2/3] Move report_signal_strength to atutil Kalle Valo
2010-05-20 0:36 ` Denis Kenzior [this message]
2010-05-20 10:23 ` Kalle Valo
2010-05-20 8:04 ` [PATCH v4 3/3] huawei: add gprs context Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005191936.23348.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox