From: Daniel Wagner <daniel.wagner@bmw-carit.de>
To: ofono@ofono.org
Subject: Re: [PATCH v1] Read EF_ICCID property of SIM
Date: Thu, 20 May 2010 15:57:13 +0200 [thread overview]
Message-ID: <20100520135713.GA18541@gumpy.localdomain> (raw)
In-Reply-To: <201005192352.36288.denkenz@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 388 bytes --]
Hi Denis,
On Thu, May 20, 2010 at 06:52:36AM +0200, Denis Kenzior wrote:
> Hi Daniel,
>
> > Tested with phonesim.
> >
> > +#define OFONO_MAX_ICCID_LENGTH 20
> > +
>
> For future reference, if a define is not used or planned to be used by plugins,
> there's no need to declare it in the public API. I fixed it for you :)
Okay, good to know. Thanks!
cheers,
daniel
next prev parent reply other threads:[~2010-05-20 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 10:01 [PATCH v1] Read EF_ICCID property of SIM Daniel Wagner
2010-05-20 4:52 ` Denis Kenzior
2010-05-20 13:57 ` Daniel Wagner [this message]
2010-05-21 14:04 ` Pekka Pessi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520135713.GA18541@gumpy.localdomain \
--to=daniel.wagner@bmw-carit.de \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox