From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: VS: [RFC PATCH 5/6] Support for concatenated SMS status report.
Date: Mon, 07 Jun 2010 12:45:40 -0500 [thread overview]
Message-ID: <201006071245.41219.denkenz@gmail.com> (raw)
In-Reply-To: <EA8B5A37FEEFC048AF3F8170D2819913B8C1280A51@jklmail01.ixonos.local>
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
Hi Pasi,
> > I suggest thinking about the data structure use some more. In
> > particular, using a list of struct mr_numbers is very inefficient. Using
> > a pair of bitmaps for mr numbers (which can only be 0..255) would be way
> > more efficient and probably would make the code much easier to write.
>
> I am not sure if I am quite getting what do you mean. Do you mean something
> like:
> struct mr_numbers {
> unsigned int mr1 : 8,
> unsigned int mr2 : 8,
> unsigned int mr3 : 8,
> unsigned int mr4 : 8
> };
No, I mean something like:
unsigned int needed_mrs[8];
unsigned int obtained_mrs[8];
where each set bit represents a number at that particular offset. See how cbs
/ sms assemblies do this.
Regards,
-Denis
next prev parent reply other threads:[~2010-06-07 17:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 11:17 Next series of delivery report patches Pasi Miettinen
2010-06-04 11:17 ` [RFC PATCH 1/6] Change in at_cds_notify for status report Pasi Miettinen
2010-06-04 11:17 ` [RFC PATCH 2/6] Add IncomingStatusReport a{sv} signal Pasi Miettinen
2010-06-04 11:17 ` [RFC PATCH 3/6] Support for basic SMS Status Report Pasi Miettinen
2010-06-04 11:17 ` [RFC PATCH 4/6] SetProperty for UseDeliveryReports Pasi Miettinen
2010-06-04 11:17 ` [RFC PATCH 5/6] Support for concatenated SMS status report Pasi Miettinen
2010-06-04 11:17 ` [RFC PATCH 6/6] Save pending SMS Status Reports to disk Pasi Miettinen
2010-06-04 22:04 ` [RFC PATCH 5/6] Support for concatenated SMS status report Denis Kenzior
2010-06-05 5:57 ` VS: " Miettinen Pasi
2010-06-07 12:22 ` Miettinen Pasi
2010-06-07 13:02 ` Miettinen Pasi
2010-06-07 17:45 ` Denis Kenzior [this message]
2010-06-04 17:08 ` [RFC PATCH 4/6] SetProperty for UseDeliveryReports Denis Kenzior
2010-06-04 17:01 ` [RFC PATCH 3/6] Support for basic SMS Status Report Denis Kenzior
2010-06-04 16:58 ` [RFC PATCH 2/6] Add IncomingStatusReport a{sv} signal Denis Kenzior
2010-06-04 16:52 ` [RFC PATCH 1/6] Change in at_cds_notify for status report Denis Kenzior
2010-06-04 11:28 ` VS: Next series of delivery report patches Miettinen Pasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006071245.41219.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox