From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: VS: [RFC PATCH 1/4] SetProperty for UseDeliveryReports. smsutil.c/h.
Date: Mon, 07 Jun 2010 13:16:42 -0500 [thread overview]
Message-ID: <201006071316.42597.denkenz@gmail.com> (raw)
In-Reply-To: <EA8B5A37FEEFC048AF3F8170D2819913B8C1280A50@jklmail01.ixonos.local>
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
Hi Pasi,
> > GSList *sms_text_prepare(const char *utf8, guint16 ref,
> > - gboolean use_16bit, int *ref_offset);
> > + gboolean use_16bit, int *ref_offset,
> > + const gboolean use_delivery_reports);
> >
> > gboolean cbs_dcs_decode(guint8 dcs, gboolean *udhi, enum sms_class *cls,
> > enum sms_charset *charset, gboolean *compressed,
>
> Ah, no need for const before gboolean, as Denis said. Do I need to send
> another patch, or can you remove it?
I applied all four patches and fixed it up for you... This time ;)
Regards,
-Denis
prev parent reply other threads:[~2010-06-07 18:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 9:53 SetProperty for UseDeliveryReports Pasi Miettinen
2010-06-07 9:53 ` [RFC PATCH 1/4] SetProperty for UseDeliveryReports. smsutil.c/h Pasi Miettinen
2010-06-07 9:53 ` [RFC PATCH 2/4] SetProperty for UseDeliveryReports. test-sms.c Pasi Miettinen
2010-06-07 9:53 ` [RFC PATCH 3/4] SetProperty for UseDeliveryReports. sms.c Pasi Miettinen
2010-06-07 9:53 ` [RFC PATCH 4/4] SetProperty for UseDeliveryReports. send-sms Pasi Miettinen
2010-06-07 10:14 ` VS: [RFC PATCH 1/4] SetProperty for UseDeliveryReports. smsutil.c/h Miettinen Pasi
2010-06-07 18:16 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006071316.42597.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox