From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 2/2] sms: status report notify
Date: Thu, 10 Jun 2010 11:14:56 -0500 [thread overview]
Message-ID: <201006101114.57074.denkenz@gmail.com> (raw)
In-Reply-To: <1276153545-22260-3-git-send-email-pasi.miettinen@ixonos.com>
[-- Attachment #1: Type: text/plain, Size: 368 bytes --]
Hi Pasi,
> + if (!sms_dcs_decode(s.deliver.dcs, &cls, NULL, NULL, NULL)) {
> + ofono_error("Unknown / Reserved DCS. Ignoring");
> + return;
> + }
> +
This reminds me, one other check I'd like you to make here is that the status
report belongs to an SMS Submit, not an SMS Command. See TP-SRQ in 23.040. I
like to be paranoid :)
Regards,
-Denis
next prev parent reply other threads:[~2010-06-10 16:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 7:05 SMS status report Pasi Miettinen
2010-06-10 7:05 ` [RFC PATCH 1/2] smsutil: Status Report assembly Pasi Miettinen
2010-06-10 7:05 ` [RFC PATCH 2/2] sms: status report notify Pasi Miettinen
2010-06-10 15:07 ` Denis Kenzior
2010-06-10 16:14 ` Denis Kenzior [this message]
2010-06-10 16:52 ` [RFC PATCH 1/2] smsutil: Status Report assembly Denis Kenzior
2010-06-11 11:35 ` VS: " Miettinen Pasi
2010-06-11 12:23 ` Miettinen Pasi
2010-06-10 14:47 ` SMS status report Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006101114.57074.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox