From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 11/11] gsmdial: Delay ppp_unref after IO processing
Date: Fri, 18 Jun 2010 12:51:45 -0500 [thread overview]
Message-ID: <201006181251.45666.denkenz@gmail.com> (raw)
In-Reply-To: <33AB447FBD802F4E932063B962385B351F309A0F@shsmsx501.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1631 bytes --]
Hi Zhenhua,
> I think we should delay the ppp shutdown stage until the LCP packet was
> well processed. I got valgrind result as below before I have patches 10/11
> and 11/11.
>
> Entering new phase: 0
> PPP Link down: 6
> ==5332== Invalid write of size 2
> ==5332== at 0x805520D: new_bytes (gathdlc.c:154)
> ==5332== by 0x804F2E6: received_data (gatio.c:119)
> ==5332== by 0x40AFDAA: g_io_unix_dispatch (giounix.c:162)
> ==5332== by 0x4078E87: g_main_context_dispatch (gmain.c:1960)
> ==5332== by 0x407C72F: g_main_context_iterate (gmain.c:2591)
> ==5332== by 0x407CB9E: g_main_loop_run (gmain.c:2799)
> ==5332== by 0x804BE5D: main (gsmdial.c:702)
> ==5332== Address 0x4382130 is 24 bytes inside a block of size 88 free'd
> ==5332== at 0x4024886: free (vg_replace_malloc.c:325)
> ==5332== by 0x4081195: g_free (gmem.c:190)
> ==5332== by 0x805557D: g_at_hdlc_unref (gathdlc.c:270)
> ==5332== by 0x8056316: g_at_ppp_unref (gatppp.c:463)
> ==5332== by 0x804AF20: ppp_disconnect (gsmdial.c:272)
> ==5332== by 0x8055CE9: ppp_dead (gatppp.c:204)
> ==5332== by 0x8055D1E: ppp_enter_phase (gatppp.c:214)
> ==5332== by 0x8055FE0: ppp_lcp_finished_notify (gatppp.c:317)
> ==5332== by 0x8057E27: lcp_finished (ppp_lcp.c:140)
> ==5332== by 0x80568DF: pppcp_this_layer_finished (ppp_cp.c:340)
> ==5332== by 0x8057446: pppcp_generate_event (ppp_cp.c:688)
> ==5332== by 0x8057B5B: pppcp_process_packet (ppp_cp.c:965)
Good catch, however I fixed it slightly differently in GAtHDLC itself. Can you
test and make sure my fix works?
Thanks,
-Denis
next prev parent reply other threads:[~2010-06-18 17:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-12 5:50 [PATCH 00/11] Add PPP server support Zhenhua Zhang
2010-06-12 5:50 ` [PATCH 01/11] gatserver: Suspend/resume GAtServer with GAtIO Zhenhua Zhang
2010-06-12 5:50 ` [PATCH 02/11] gatserver: Check for disconnection when resuming Zhenhua Zhang
2010-06-12 5:50 ` [PATCH 03/11] gatppp: Add PPP server extension Zhenhua Zhang
2010-06-12 5:50 ` [PATCH 04/11] atmodem: Fix GAtPPPConnectFunc interface change Zhenhua Zhang
2010-06-12 5:50 ` [PATCH 05/11] test-server: Fix GIOChannel leak in create_tty Zhenhua Zhang
2010-06-12 5:50 ` [PATCH 06/11] test-server: Add PPP server support Zhenhua Zhang
2010-06-12 5:50 ` [PATCH 07/11] test-server: Configure network interface Zhenhua Zhang
2010-06-12 5:50 ` [PATCH 08/11] gsmdial: Configure network interface for PPP Zhenhua Zhang
2010-06-12 5:50 ` [PATCH 09/11] gsmdial: Unref ppp when we get disconnected Zhenhua Zhang
2010-06-12 5:50 ` [PATCH 10/11] test-server: Delay ppp_unref after IO processing Zhenhua Zhang
2010-06-12 5:50 ` [PATCH 11/11] gsmdial: " Zhenhua Zhang
2010-06-12 6:03 ` Zhang, Zhenhua
2010-06-18 17:51 ` Denis Kenzior [this message]
2010-06-18 17:50 ` [PATCH 09/11] gsmdial: Unref ppp when we get disconnected Denis Kenzior
2010-06-18 17:50 ` [PATCH 05/11] test-server: Fix GIOChannel leak in create_tty Denis Kenzior
2010-06-18 17:49 ` [PATCH 03/11] gatppp: Add PPP server extension Denis Kenzior
2010-06-21 2:38 ` Zhang, Zhenhua
2010-06-22 4:26 ` Denis Kenzior
2010-06-22 6:31 ` Zhang, Zhenhua
2010-06-18 17:31 ` [PATCH 02/11] gatserver: Check for disconnection when resuming Denis Kenzior
2010-06-18 17:31 ` [PATCH 01/11] gatserver: Suspend/resume GAtServer with GAtIO Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006181251.45666.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox