From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/8] stkutil: Refactor command parser error handling
Date: Wed, 23 Jun 2010 14:36:43 -0500 [thread overview]
Message-ID: <201006231436.44825.denkenz@gmail.com> (raw)
In-Reply-To: <1277205651-29369-1-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
Hi Andrew,
> When parsing the full command fails but Command Details has been parsed,
> return a struct stk_command containing this information and the type of
> parsing problem found. We need the command details to be able to
> even respond to the command.
>
> This patch also makes the parser skip over unknown data objects found
> in the BER-TLV, if they don't have Comprehension Required set.
I double checked the logic and it looked sound to me. Patch has been applied,
thanks.
Regards,
-Denis
prev parent reply other threads:[~2010-06-23 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 11:20 [PATCH 1/8] stkutil: Refactor command parser error handling Andrzej Zaborowski
2010-06-22 11:20 ` [PATCH 2/8] stk: Allow registering proactive command handlers Andrzej Zaborowski
2010-06-23 19:44 ` Denis Kenzior
2010-06-23 22:08 ` Andrzej Zaborowski
2010-06-22 11:20 ` [PATCH 3/8] stk: Handle the More Time command as a nop Andrzej Zaborowski
2010-06-22 11:20 ` [PATCH 4/8] stk: Add SimApplication interface Andrzej Zaborowski
2010-06-23 21:25 ` Denis Kenzior
2010-06-22 11:20 ` [PATCH 5/8] stk: Forget previous command if a new one comes Andrzej Zaborowski
2010-06-22 11:20 ` [PATCH 6/8] Add a proactive command cancel notification Andrzej Zaborowski
2010-06-22 11:20 ` [PATCH 7/8] mbmmodem: Cancel running command on *STKEND Andrzej Zaborowski
2010-06-22 11:20 ` [PATCH 8/8] stk: Handle the Display Text command Andrzej Zaborowski
2010-06-23 19:36 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006231436.44825.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox