From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/6] ppp: Fix incorrect packet length for little-endian
Date: Wed, 23 Jun 2010 18:20:26 -0500 [thread overview]
Message-ID: <201006231820.26732.denkenz@gmail.com> (raw)
In-Reply-To: <1277286402-22312-2-git-send-email-zhenhua.zhang@intel.com>
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
Hi Zhenhua,
> packet->length is in TCP/IP network byte order. It needs to call ntohs()
> to convert to host byte order, which is little-endian.
Nice catch. Patch has been applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2010-06-23 23:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 9:46 [PATCH 0/6] Add PPP server support Zhenhua Zhang
2010-06-23 9:46 ` [PATCH 1/6] ppp: Fix incorrect packet length for little-endian Zhenhua Zhang
2010-06-23 9:46 ` [PATCH 2/6] gatppp: Add PPP server extension Zhenhua Zhang
2010-06-23 9:46 ` [PATCH 3/6] atmodem: Fix GAtPPPConnectFunc interface change Zhenhua Zhang
2010-06-23 9:46 ` [PATCH 4/6] test-server: Add PPP server support Zhenhua Zhang
2010-06-23 9:46 ` [PATCH 5/6] test-server: Configure network interface Zhenhua Zhang
2010-06-23 9:46 ` [PATCH 6/6] gsmdial: Configure network interface for PPP Zhenhua Zhang
2010-06-23 23:19 ` [PATCH 2/6] gatppp: Add PPP server extension Denis Kenzior
2010-06-24 6:23 ` Zhang, Zhenhua
2010-06-24 6:26 ` Zhang, Zhenhua
2010-06-23 23:20 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006231820.26732.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox