From: Gustavo F. Padovan <padovan@profusion.mobi>
To: ofono@ofono.org
Subject: Re: [PATCH -v3 1/5] modem: only unref pending if it is a powered pending
Date: Fri, 03 Dec 2010 19:37:04 -0200 [thread overview]
Message-ID: <20101203213704.GA4432@vigoh> (raw)
In-Reply-To: <1291402377-9211-1-git-send-email-padovan@profusion.mobi>
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
* Gustavo F. Padovan <padovan@profusion.mobi> [2010-12-03 16:52:53 -0200]:
> ---
> src/modem.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/modem.c b/src/modem.c
> index 52e647b..d6ab316 100644
> --- a/src/modem.c
> +++ b/src/modem.c
> @@ -804,7 +804,7 @@ void ofono_modem_set_powered(struct ofono_modem *modem, ofono_bool_t powered)
> modem->timeout = 0;
> }
>
> - if (modem->pending != NULL) {
> + if (modem->powered_pending != powered && modem->pending != NULL) {
This one is wrong, I'll resend it. It should be modem->powered instead of
powered.
--
Gustavo F. Padovan
http://profusion.mobi
next prev parent reply other threads:[~2010-12-03 21:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 18:52 [PATCH -v3 1/5] modem: only unref pending if it is a powered pending Gustavo F. Padovan
2010-12-03 18:52 ` [PATCH -v3 2/5] modem: add ofono_modem_reset() to modem.h Gustavo F. Padovan
2010-12-03 18:52 ` [PATCH -v3 3/5] Add ofono_modem_reset() Gustavo F. Padovan
2010-12-03 18:52 ` [PATCH -v3 4/5] phonesim: Add modem reset trigger Gustavo F. Padovan
2010-12-03 18:52 ` [PATCH -v3 5/5] modem: add support to restore state when resetting the modem Gustavo F. Padovan
2010-12-07 3:48 ` Denis Kenzior
2010-12-07 18:31 ` [PATCH] " Gustavo F. Padovan
2010-12-18 1:13 ` Denis Kenzior
2010-12-07 3:00 ` [PATCH -v3 4/5] phonesim: Add modem reset trigger Denis Kenzior
2010-12-07 3:00 ` [PATCH -v3 3/5] Add ofono_modem_reset() Denis Kenzior
2010-12-07 2:58 ` [PATCH -v3 2/5] modem: add ofono_modem_reset() to modem.h Denis Kenzior
2010-12-03 21:37 ` Gustavo F. Padovan [this message]
2010-12-03 21:40 ` [PATCH] modem: only unref pending if it is a powered pending Gustavo F. Padovan
2010-12-07 2:57 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101203213704.GA4432@vigoh \
--to=padovan@profusion.mobi \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox