From: Holger Hans Peter Freyther <holger@freyther.de>
To: ofono@ofono.org
Subject: Re: [PATCH] modem: Make it possible to identify the physical device of the modemy
Date: Thu, 01 Nov 2012 17:16:08 +0100 [thread overview]
Message-ID: <20121101161608.GH26158@xiaoyu.lan> (raw)
In-Reply-To: <509245B1.5000804@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 942 bytes --]
On Thu, Nov 01, 2012 at 04:49:37AM -0500, Denis Kenzior wrote:
> Hi Holger,
> I really do not think exposing the device name is a good idea.
> First of all, no normal application can make use of it anyway. Once
> the modem is powered on oFono takes exclusive rights to it.
> Secondly, most USB sticks are actually multi-device groupings
> anyway, so this property really makes no sense.
the alternative would be to add the sysfs path directly but this
probably doesn't change your argument.
>
> Why don't you simply assign a name to the modem using
> ofono_modem_set_name. This can be done by assigning the name
> directly in the udev rule and having the necessary magic inside
> plugins/udev.c. The name can be anything you wish in that case.
I will have to take a look at this. I never wrote advanced udev
rules and I don't know how much sense it makes to put handling
for our product into plugins/udev.c.
h
next prev parent reply other threads:[~2012-11-01 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 10:39 [PATCH] modem: Make it possible to identify the physical device of the modem Holger Hans Peter Freyther
2012-11-01 9:49 ` Denis Kenzior
2012-11-01 16:16 ` Holger Hans Peter Freyther [this message]
2012-11-01 12:39 ` [PATCH] modem: Make it possible to identify the physical device of the modemy Denis Kenzior
2012-11-01 10:41 ` [PATCH] modem: Make it possible to identify the physical device of the modem Holger Freyther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101161608.GH26158@xiaoyu.lan \
--to=holger@freyther.de \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox