From: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
To: ofono@ofono.org
Subject: Re: [PATCH 1/8] hfpmodem: Add codec watcher register
Date: Wed, 10 Apr 2013 16:31:08 -0300 [thread overview]
Message-ID: <20130410193108.GA2098@samus> (raw)
In-Reply-To: <5164C3FE.9070600@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
Hi Denis,
[snip]
> >+guint hfp_slc_codec_watch_register(struct hfp_slc_info *info,
> >+ hfp_slc_codec_watch_cb_t cb, void *user_data)
> >+{
> >+ struct codec_watch *watch = g_new0(struct codec_watch, 1);
> >+
> >+ watch->slc = info;
> >+ watch->cb = cb;
> >+ watch->user_data = user_data;
> >+
> >+ return g_at_chat_register(info->chat, "+BCS:", bcs_notify, FALSE,
> >+ watch, g_free);
> >+}
>
> Why would you do this in the SLC ? The SLC establishment only
> requires HF to send a BAC after the BRSF has been exchanged. We do
> this successfully in brsf_cb. I do not see why we can't monitor
> +BCS inside plugins/hfp_hf_bluez5.c?
The only point was to avoid having any AT logic inside the hfp_hf_bluez5
plugin. Will send an updated version with this logic inside hfp_hf_bluez5. It
does indeed make the code easier to follow.
Cheers,
--
Vinicius
next prev parent reply other threads:[~2013-04-10 19:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 20:45 [PATCH 0/8] HFP 1.6 codec selection Vinicius Costa Gomes
2013-04-09 20:45 ` [PATCH 1/8] hfpmodem: Add codec watcher register Vinicius Costa Gomes
2013-04-10 1:44 ` Denis Kenzior
2013-04-10 19:31 ` Vinicius Costa Gomes [this message]
2013-04-09 20:45 ` [PATCH 2/8] hfp_hf_bluez5: Register codec watcher Vinicius Costa Gomes
2013-04-09 20:45 ` [PATCH 3/8] include: ofono_handsfree_card_select_codec() Vinicius Costa Gomes
2013-04-09 20:45 ` [PATCH 4/8] handsfree-audio: Implement ofono_handsfree_card_select_codec() Vinicius Costa Gomes
2013-04-10 1:49 ` Denis Kenzior
2013-04-09 20:45 ` [PATCH 5/8] hfp_hf_bluez5: Set the audio codec in the card Vinicius Costa Gomes
2013-04-09 20:45 ` [PATCH 6/8] handsfree-audio: Send the selected codec Vinicius Costa Gomes
2013-04-09 20:45 ` [PATCH 7/8] handsfree-audio: Set CVSD as default in the card Vinicius Costa Gomes
2013-04-09 20:45 ` [PATCH 8/8] handsfree-audio: Enable wideband speech if defer is enabled Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410193108.GA2098@samus \
--to=vinicius.gomes@openbossa.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox