From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: ofono@ofono.org
Subject: [PATCH v6 2/3] doc/handsfree-audio-api: Add Acquire method
Date: Thu, 04 May 2017 11:22:35 +0300 [thread overview]
Message-ID: <20170504082236.9977-2-luiz.dentz@gmail.com> (raw)
In-Reply-To: <20170504082236.9977-1-luiz.dentz@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1767 bytes --]
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This adds Acquire method which can be used by agents that require
pulling the fd directly instead of waiting a NewConnection.
Note: sounds servers like PulseAudio do auto suspend streams when idle
for a certain amount of time and once anything happens it will resume
the stream, though this all happens in the so called IO thread in a
blocking fashion making it impossible to receive the fd via NewConnetion
causing the stream to fail to resume. There are other forms to work
around but this seems to be most convenient as we do want the auto
suspend feature to work properly but letting the stream to fail to
resume may create unexpected artifacts while the NewConnection is
handled in main thread.
---
doc/handsfree-audio-api.txt | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/doc/handsfree-audio-api.txt b/doc/handsfree-audio-api.txt
index d82035c..87d51cf 100644
--- a/doc/handsfree-audio-api.txt
+++ b/doc/handsfree-audio-api.txt
@@ -76,6 +76,22 @@ Methods dict GetProperties()
[service].Error.NotImplemented
[service].Error.NotAllowed
+ fd, byte Acquire()
+
+ Attempts to establish the SCO audio connection
+ returning the filedescriptor of the connection and the
+ codec in use.
+
+ Note: Contrary to Connect this does not call
+ NewConnection so it can be called in a blocking
+ manner.
+
+ Possible Errors: [service].Error.InProgress
+ [service].Error.Failed
+ [service].Error.NotAvailable
+ [service].Error.NotImplemented
+ [service].Error.NotAllowed
+
Signals PropertyChanged(string name, variant value)
This signal indicates a changed value of the given
--
2.9.3
next prev parent reply other threads:[~2017-05-04 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 8:22 [PATCH v6 1/3] hfp_hf_bluez5: Rework code handling device changes Luiz Augusto von Dentz
2017-05-04 8:22 ` Luiz Augusto von Dentz [this message]
2017-05-04 8:22 ` [PATCH v6 3/3] handsfree-audio: Add Acquire implementation Luiz Augusto von Dentz
2017-05-04 17:35 ` [PATCH v6 1/3] hfp_hf_bluez5: Rework code handling device changes Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504082236.9977-2-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox