From: Clement Viel <vielclement@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/3] sim800: add udev detection
Date: Wed, 19 Sep 2018 22:10:00 +0200 [thread overview]
Message-ID: <20180919201000.GE3536@turing> (raw)
In-Reply-To: <72714607-51ea-ca77-42fc-77ed237030e0@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
On Wed, Sep 19, 2018 at 03:03:57PM -0500, Denis Kenzior wrote:
Hi,
> Hi,
>
> >>
> >>So I'm confused now. If sim800 is a serial device, why do you have all this
> >>here? Shouldn't this be handled by setup_serial_modem ?
> >>
> >
> >Because the modem was seen through a serial/USB converter, my kernel sees it as a USB device. So I used this function.
> >Should this be coded in a more generic way ?
> >
>
> Yes, you should use the setup_serial_modem bits and the UDEV rule outlined
> in patch 3 should take care of the detection.
>
All right, I'll change the detection and setup in next patch set.
> Regards,
> -Denis
Regards
Clem
next prev parent reply other threads:[~2018-09-19 20:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 20:36 [PATCH 1/3] sim800: adding support for Simcom SIM800 modem =?unknown-8bit?q?Cl=C3=A9mentViel?=
2018-09-18 20:36 ` [PATCH 2/3] sim800: add udev detection =?unknown-8bit?q?Cl=C3=A9mentViel?=
2018-09-19 16:46 ` Denis Kenzior
2018-09-19 20:01 ` Clement Viel
2018-09-19 20:03 ` Denis Kenzior
2018-09-19 20:10 ` Clement Viel [this message]
2018-09-18 20:36 ` [PATCH 3/3] sim800: adding documentation to inform about the udev rule the user must add =?unknown-8bit?q?Cl=C3=A9mentViel?=
2018-09-19 16:43 ` Denis Kenzior
2018-09-19 19:25 ` Clement Viel
2018-09-19 19:27 ` =?unknown-8bit?q?Pi=C4=8Dugins?= Arsenijs
2018-09-20 22:05 ` Pavel Machek
2018-09-19 16:51 ` [PATCH 1/3] sim800: adding support for Simcom SIM800 modem Denis Kenzior
2018-09-19 17:03 ` =?unknown-8bit?q?Pi=C4=8Dugins?= Arsenijs
2018-09-19 19:52 ` Clement Viel
2018-09-19 19:45 ` Clement Viel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919201000.GE3536@turing \
--to=vielclement@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox