Open Source Telephony
 help / color / mirror / Atom feed
From: Giacinto Cifelli <gciofono@gmail.com>
To: ofono@ofono.org
Subject: [PATCH] atmodem/sms: no mms support for Gemalto
Date: Wed, 26 Sep 2018 13:32:32 +0200	[thread overview]
Message-ID: <20180926113232.22923-1-gciofono@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

---
 drivers/atmodem/sms.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
index 64d0f6e8..db04cb1e 100644
--- a/drivers/atmodem/sms.c
+++ b/drivers/atmodem/sms.c
@@ -219,16 +219,21 @@ static void at_cmgs(struct ofono_sms *sms, const unsigned char *pdu,
 	char buf[512];
 	int len;
 
-	switch(data->vendor) {
-	case OFONO_VENDOR_GEMALTO:
-		break;
-	default:
-		if (mms) {
+	if (mms) {
+
+		switch (data->vendor) {
+
+		case OFONO_VENDOR_GEMALTO:
+			/* no mms support */
+			break;
+
+		default:
 			snprintf(buf, sizeof(buf), "AT+CMMS=%d", mms);
 			g_at_chat_send(data->chat, buf, none_prefix,
 					NULL, NULL, NULL);
+			break;
+
 		}
-		break;
 	}
 
 	len = snprintf(buf, sizeof(buf), "AT+CMGS=%d\r", tpdu_len);
-- 
2.17.1


             reply	other threads:[~2018-09-26 11:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-26 11:32 Giacinto Cifelli [this message]
2018-09-26 21:34 ` [PATCH] atmodem/sms: no mms support for Gemalto Denis Kenzior
2018-09-27  2:10   ` Giacinto Cifelli
  -- strict thread matches above, loose matches on Subject: below --
2018-09-27  2:43 Giacinto Cifelli
2018-09-27 12:32 ` Denis Kenzior
2018-09-25 13:19 [PATCH] atmodem/sms: no mms support for gemalto Giacinto Cifelli
2018-09-25 14:49 ` Denis Kenzior
2018-09-26  3:30   ` Giacinto Cifelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180926113232.22923-1-gciofono@gmail.com \
    --to=gciofono@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox