From: Pavel Machek <pavel@ucw.cz>
To: ofono@ofono.org
Subject: [PATCH] Fix error handling in at_cmt_notify()
Date: Thu, 27 Sep 2018 23:47:24 +0200 [thread overview]
Message-ID: <20180927214724.GD17346@amd> (raw)
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
at_cmt_notify() calls ofono_error even in case stuff is
okay. Fix that.
diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
index 68b89862..217971e7 100644
--- a/drivers/atmodem/sms.c
+++ b/drivers/atmodem/sms.c
@@ -440,6 +436,8 @@ static void at_cmt_notify(GAtResult *result, gpointer user_data)
if (data->vendor != OFONO_VENDOR_SIMCOM)
at_ack_delivery(sms);
+ return;
+
err:
ofono_error("Unable to parse CMT notification");
}
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next reply other threads:[~2018-09-27 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 21:47 Pavel Machek [this message]
2018-09-27 22:18 ` [PATCH] Fix error handling in at_cmt_notify() Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927214724.GD17346@amd \
--to=pavel@ucw.cz \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox