From: Giacinto Cifelli <gciofono@gmail.com>
To: ofono@ofono.org
Subject: [PATCH 4/6] plugins/provisioning and mbpi: support for auth NONE
Date: Thu, 04 Oct 2018 07:05:22 +0200 [thread overview]
Message-ID: <20181004050523.9772-1-gciofono@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1765 bytes --]
support of 'none' in file-provisioning and in mbpi.
The default authentication method is set to 'none'.
---
plugins/file-provision.c | 6 +++++-
plugins/mbpi.c | 5 ++++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/plugins/file-provision.c b/plugins/file-provision.c
index d4846a65..2bd516ff 100644
--- a/plugins/file-provision.c
+++ b/plugins/file-provision.c
@@ -97,14 +97,18 @@ static int config_file_provision_get_settings(const char *mcc,
value = g_key_file_get_string(key_file, setting_group,
"internet.AuthenticationMethod", NULL);
+ /* select default authentication method */
+ (*settings)[0].auth_method = OFONO_GPRS_AUTH_METHOD_NONE;
+
if (value != NULL) {
+
if (g_strcmp0(value, "chap") == 0)
(*settings)[0].auth_method =
OFONO_GPRS_AUTH_METHOD_CHAP;
else if (g_strcmp0(value, "pap") == 0)
(*settings)[0].auth_method =
OFONO_GPRS_AUTH_METHOD_PAP;
- else
+ else if (g_strcmp0(value, "none") != 0)
DBG("Unknown auth method: %s", value);
g_free(value);
diff --git a/plugins/mbpi.c b/plugins/mbpi.c
index ae92c762..d101085f 100644
--- a/plugins/mbpi.c
+++ b/plugins/mbpi.c
@@ -148,11 +148,14 @@ static void authentication_start(GMarkupParseContext *context,
return;
}
+ /* select default authentication method */
+ *auth_method = OFONO_GPRS_AUTH_METHOD_NONE;
+
if (strcmp(text, "chap") == 0)
*auth_method = OFONO_GPRS_AUTH_METHOD_CHAP;
else if (strcmp(text, "pap") == 0)
*auth_method = OFONO_GPRS_AUTH_METHOD_PAP;
- else
+ else if (strcmp(text, "none") != 0)
mbpi_g_set_error(context, error, G_MARKUP_ERROR,
G_MARKUP_ERROR_UNKNOWN_ATTRIBUTE,
"Unknown authentication method: %s",
--
2.17.1
next reply other threads:[~2018-10-04 5:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 5:05 Giacinto Cifelli [this message]
2018-10-04 5:05 ` [PATCH 6/6] drivers: support for auth NONE Giacinto Cifelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004050523.9772-1-gciofono@gmail.com \
--to=gciofono@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox