Open Source Telephony
 help / color / mirror / Atom feed
From: Giacinto Cifelli <gciofono@gmail.com>
To: ofono@ofono.org
Subject: [PATCH 2/6] lte.h: added proto and authentication handling
Date: Wed, 10 Oct 2018 08:54:50 +0200	[thread overview]
Message-ID: <20181010065454.15232-2-gciofono@gmail.com> (raw)
In-Reply-To: <20181010065454.15232-1-gciofono@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2243 bytes --]

The ofono_lte_default_attach_info is extended with protocol,
authentication method, username and password.
The transmission of this info from the src to the atom happens
through the existing set_default_attach_info.
A signal is emitted when one of these properties changes

There is a new function in the atom, set_reg_info, that the atom can
choose to use as a hint to transmit the information to the modem.

The newly added global function ofono_lte_set_reg_info locates the lte
atom if present, otherwise returns, and triggers the atom function
set_reg_info.
This function is to be called in src/modem just before setting it
online.
---
 include/lte.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/include/lte.h b/include/lte.h
index 0f2501c0..3f04984a 100644
--- a/include/lte.h
+++ b/include/lte.h
@@ -3,6 +3,7 @@
  *  oFono - Open Source Telephony
  *
  *  Copyright (C) 2016  Endocode AG. All rights reserved.
+ *  Copyright (C) 2018 Gemalto M2M
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -32,6 +33,10 @@ struct ofono_lte;
 
 struct ofono_lte_default_attach_info {
 	char apn[OFONO_GPRS_MAX_APN_LENGTH + 1];
+	enum ofono_gprs_proto proto;
+	enum ofono_gprs_auth_method auth_method;
+	char username[OFONO_GPRS_MAX_USERNAME_LENGTH + 1];
+	char password[OFONO_GPRS_MAX_PASSWORD_LENGTH + 1];
 };
 
 typedef void (*ofono_lte_cb_t)(const struct ofono_error *error, void *data);
@@ -43,6 +48,8 @@ struct ofono_lte_driver {
 	void (*set_default_attach_info)(const struct ofono_lte *lte,
 			const struct ofono_lte_default_attach_info *info,
 			ofono_lte_cb_t cb, void *data);
+	void (*set_reg_info)(const struct ofono_lte *lte,
+			const struct ofono_lte_default_attach_info *info);
 };
 
 int ofono_lte_driver_register(const struct ofono_lte_driver *d);
@@ -61,6 +68,8 @@ void ofono_lte_set_data(struct ofono_lte *lte, void *data);
 
 void *ofono_lte_get_data(const struct ofono_lte *lte);
 
+void ofono_lte_set_reg_info(struct ofono_modem *modem);
+
 struct ofono_modem *ofono_lte_get_modem(const struct ofono_lte *lte);
 
 #ifdef __cplusplus
-- 
2.17.1


  reply	other threads:[~2018-10-10  6:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10  6:54 [PATCH 1/6] lte-api: protocol and authentication properties Giacinto Cifelli
2018-10-10  6:54 ` Giacinto Cifelli [this message]
2018-10-10  6:54 ` [PATCH 3/6] src/lte: added proto and authentication handling Giacinto Cifelli
2018-10-11 20:07   ` Jonas Bonn
2018-10-12  2:57     ` Giacinto Cifelli
2018-10-12  3:43   ` Denis Kenzior
2018-10-12  6:36     ` Giacinto Cifelli
2018-10-12 17:47       ` Denis Kenzior
2018-10-10  6:54 ` [PATCH 5/6] atmodem/lte: " Giacinto Cifelli
2018-10-11 19:51   ` Jonas Bonn
2018-10-12  2:54     ` Giacinto Cifelli
2018-10-12  3:56   ` Denis Kenzior
2018-10-12  4:56     ` Giacinto Cifelli
2018-10-10  6:54 ` [PATCH 4/6] src/modem: notify lte driver before going online Giacinto Cifelli
2018-10-11 20:19   ` Jonas Bonn
2018-10-12  3:04     ` Giacinto Cifelli
2018-10-12  6:17       ` Jonas Bonn
2018-10-12  6:19         ` Giacinto Cifelli
2018-10-10  6:54 ` [PATCH 6/6] Gemalto contributors Giacinto Cifelli
2018-10-12  4:10   ` Denis Kenzior
2018-10-12  4:15     ` Giacinto Cifelli
2018-10-11 19:07 ` [PATCH 1/6] lte-api: protocol and authentication properties Jonas Bonn
2018-10-12  2:41   ` Giacinto Cifelli
2018-10-12  4:06     ` Denis Kenzior
2018-10-12  4:13       ` Giacinto Cifelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181010065454.15232-2-gciofono@gmail.com \
    --to=gciofono@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox