Open Source Telephony
 help / color / mirror / Atom feed
From: Giacinto Cifelli <gciofono@gmail.com>
To: ofono@ofono.org
Subject: [RFC PATCH 0/1] atmodem/lte: added Gemalto vendor
Date: Sat, 13 Oct 2018 10:09:19 +0200	[thread overview]
Message-ID: <20181013080920.3487-1-gciofono@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 931 bytes --]

I would like to submit for review the following patch, for adding
the Gemalto vendor. I submit in a single patch also the modifications
under discussion in a separate thread, for ease of reading.

The main point I would like to ask is where to put the vendor-specific
but shared functions for formating the AT commands, because the same
procedures are used for gprs-context.

The point is valid also for other vendors: for example uBlox requires
the following format: "CHAP:apn" or "PAP:apn", if there is a context
authentication, in the AccessPoint string, on top of the authentication
command.


Giacinto Cifelli (1):
  atmodem/lte: Gemalto vendor specific extension

 drivers/atmodem/atutil.c | 103 +++++++++++++++++++++++++
 drivers/atmodem/atutil.h |  27 +++++++
 drivers/atmodem/lte.c    | 161 ++++++++++++++++++++++++++++++++++++---
 3 files changed, 281 insertions(+), 10 deletions(-)

-- 
2.17.1


             reply	other threads:[~2018-10-13  8:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-13  8:09 Giacinto Cifelli [this message]
2018-10-13  8:09 ` [RFC PATCH 1/1] atmodem/lte: Gemalto vendor specific extension Giacinto Cifelli
2018-10-14 17:56   ` Jonas Bonn
2018-10-14 18:04     ` Giacinto Cifelli
2018-10-15 18:37       ` Denis Kenzior
2018-10-15 18:29   ` Denis Kenzior
2018-10-15 18:59     ` Giacinto Cifelli
2018-10-16  5:22     ` Giacinto Cifelli
2018-10-16 18:06       ` Denis Kenzior
2018-10-18  7:57         ` Giacinto Cifelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181013080920.3487-1-gciofono@gmail.com \
    --to=gciofono@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox