On Thu, Nov 08, 2018 at 10:59:30AM -0600, Denis Kenzior wrote: Hi Denis, > Hi Clement, > >>>+ { "sim800", setup_serial_modem }, > I think I must keep this line > >>>because the udev rule added by the user > will specify that modem is "OFONO_DRIVER=sim800" so udevng.c must know what > to do with that. > This is kind of weird that we have a driver line for a modem driver that > doesn't exist. We never do things this way. Why don't you just modify the > driver instructions to have OFONO_DRIVER=sim900 instead? > I agree with you, I was thinking the sim800 must be mentioned to avoid confusing doc/sim900.txt to mention that sim800 is supported by this driver. Then, keep in the users. > Also, we could simply rename the sim900 driver into sim_x00 or simcom_serial > or something too. That could make things a bit more clear. I think we can keep that in mind for further development. > > Regards, > -Denis Just tell me whether I should add mention of sim800 in sim900.txt or rename sim900.txt in simcom.txt to mention the two drivers. Then I'll upload the patchset with doc in it. Regards Clement