From: Clement Viel <vielclement@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 3/3] sim800: add udev detection.
Date: Mon, 12 Nov 2018 15:21:51 +0100 [thread overview]
Message-ID: <20181112142151.GB5978@turing> (raw)
In-Reply-To: <334c45c5-065c-dca1-d4bc-2f7c75cfae8f@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On Thu, Nov 08, 2018 at 10:59:30AM -0600, Denis Kenzior wrote:
> Hi Clement,
> >>>+ { "sim800", setup_serial_modem }, > I think I must keep this line
> >>>because the udev rule added by the user
> will specify that modem is "OFONO_DRIVER=sim800" so udevng.c must know what
> to do with that.
> This is kind of weird that we have a driver line for a modem driver that
> doesn't exist. We never do things this way. Why don't you just modify the
> driver instructions to have OFONO_DRIVER=sim900 instead?
>
> Also, we could simply rename the sim900 driver into sim_x00 or simcom_serial
> or something too. That could make things a bit more clear.
>
> Regards,
> -Denis
Moreover if we go for the OFONO_DRIVER=sim900 solution, plugins/udevng.c will stay
the same.
next prev parent reply other threads:[~2018-11-12 14:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 14:00 [PATCH 3/3] sim800: add udev detection Clement Viel
2018-11-07 14:02 ` Jonas Bonn
2018-11-07 14:08 ` Clement Viel
2018-11-08 16:59 ` Denis Kenzior
2018-11-12 14:16 ` Clement Viel
2018-11-12 16:34 ` Denis Kenzior
2018-11-12 14:21 ` Clement Viel [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-07 10:14 [PATCH 1/3] sim800: add support for sim800 modem Clement Viel
2018-11-07 10:14 ` [PATCH 3/3] sim800: add udev detection Clement Viel
2018-11-07 13:30 ` Jonas Bonn
2018-11-07 13:58 ` Clement Viel
2018-10-15 17:27 [PATCH 1/3] sim800: add support for sim800 modem Clement Viel
2018-10-15 17:27 ` [PATCH 3/3] sim800: add udev detection Clement Viel
2018-10-03 13:28 [PATCH 1/3] sim800: add support for sim800 modem Clement Viel
2018-10-03 13:28 ` [PATCH 3/3] sim800: add udev detection Clement Viel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112142151.GB5978@turing \
--to=vielclement@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox