Open Source Telephony
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: ofono@ofono.org
Subject: Re: Trouble compiling ... Re: ofono fails to compile on gcc-6.3
Date: Sat, 29 Dec 2018 21:30:46 +0100	[thread overview]
Message-ID: <20181229203046.GA1949@amd> (raw)
In-Reply-To: <53dd54d0-9b4d-739f-ef1c-e0268998b29c@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2192 bytes --]

Hi!

> >>   CC       drivers/rilmodem/network-registration.o
> >>   drivers/rilmodem/network-registration.c:40:32: error: unknown option
> >>   after ‘#pragma GCC diagnostic’ kind [-Werror=pragmas]
> >>    #pragma GCC diagnostic ignored "-Wrestrict"
> >>cc1: error: unrecognized command line option ‘-Wno-format-truncation’
> >>   [-Werror]
> >>   cc1: all warnings being treated as errors
> >>
> >>I commented out #pragma, and this allows compilation to
> >>continue... until I hit same issue in
> >>drivers/rilmodem/call-forwarding.c:41:32:
> 
> Yeah, I'm not sure what to do with these.  Marcel put in the #pragmas to
> silence some warnings on GCC 8.x, but it seems GCC 6 doesn't know about
> these #pragma directives and complains.

/* Test for GCC > 3.2.0 */
#if __GNUC__ > 3 || \
    (__GNUC__ == 3 && (__GNUC_MINOR__ > 2 || \
                           (__GNUC_MINOR__ == 2 && \
			                           __GNUC_PATCHLEVEL__
						   > 0))
#pragma...
#endif

?

> >Plus there's new one:
> >   CC       drivers/rilmodem/sim.o
> >   drivers/rilmodem/sim.c: In function ‘ril_file_io_cb’:
> >   drivers/rilmodem/sim.c:381:49: warning: passing argument 2 of
> >   ‘l_util_from_hexstring’ from incompatible pointer type
> >     response = l_util_from_hexstring(hex_response, &len);
> >                                                      ^
> >						     In file included
> >   from ./ell/ell.h:1:0,
> >                    from drivers/rilmodem/sim.c:34:
> >		   ./ell/util.h:271:16: note: expected ‘size_t *’ but
> >   argument is of type ‘long int *’
> >    unsigned char *l_util_from_hexstring(const char *str, size_t
> >   *out_len);
> >                   ^
> 
> Ah darn, thought I got them all but seems I missed one.  Should be fixed
> now.

Ok, good.

Would it be possible to get reasonable error message when ell is not
found?

"ell not found, you need to install it, please see README file"? It
took me a while to figure out...

Thanks,

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2018-12-29 20:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04  9:44 ofono fails to compile on gcc-6.3 Pavel Machek
2018-09-04 11:01 ` Giacinto Cifelli
2018-12-29  9:53 ` Trouble compiling ... " Pavel Machek
2018-12-29 20:20   ` Denis Kenzior
2018-12-29 20:30     ` Pavel Machek [this message]
2018-12-29 21:08       ` Denis Kenzior
2019-01-22 17:07         ` Marcel Holtmann
2018-12-29 22:24       ` [PATCH] fix compilation " Pavel Machek
2018-12-29 22:47         ` [PATCH] document getting of ell, point people at useful docs Pavel Machek
2019-01-14 11:17           ` Pavel Machek
2019-01-22 16:50           ` Marcel Holtmann
2019-02-01 22:25             ` Pavel Machek
2019-02-02 12:18               ` Marcel Holtmann
2019-01-22 17:03         ` [PATCH] fix compilation on gcc-6.3 Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181229203046.GA1949@amd \
    --to=pavel@ucw.cz \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox