Re: [rfc] Motorola Droid 4 voice: integrate into atmodem or completely separate?

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]

Hi!

> >Droid 4 has ... something similar to AT commands, but not quite. For
> >voice calls, I modified atmodem... but I guess there are so many
> >changes that creating separate motorolamodem/voicecall.c might be
> >an option? (send_clcc() changes make sense as a cleanup, and were sent
> >in separate mail.)
> 
> Since it looks like the Modem does actually provide some rudimentary
> unsolicited call state notifications via CIEV, you're better off just
> writing a custom driver.  CLCC polling logic is actually quite complex as it
> is, so adding vendor branching to it just makes things worse. Also the
> driver is likely to be much simpler if you can rely on unsolicited call
> state reporting events.

Thanks for feedback. Done, but there are more cleanups possible.

> The send_clcc change does sort of make sense separately.

Yes, you should have it separate in your inbox ;-). If not, let me
know and I'll resend.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]