From: Tony Lindgren <tony@atomide.com>
To: Denis Kenzior <denkenz@gmail.com>
Cc: Adam Pigg <piggz1@gmail.com>,
ofono@lists.linux.dev,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Merlijn Wajer <merlijn@wizzup.org>,
Carl Philipp Klemm <philipp@uvos.xyz>
Subject: Re: RFC - Add AT interface to qmi device
Date: Tue, 21 May 2024 06:11:05 +0300 [thread overview]
Message-ID: <20240521031105.GC5153@atomide.com> (raw)
In-Reply-To: <d4d09174-1f12-420d-8ba2-96e2f3f9aa7d@gmail.com>
* Denis Kenzior <denkenz@gmail.com> [240520 18:58]:
> > > Have you considered simply using AT commands for calls and SMS?
> >
> > At least on Droid4 the ttyUSB AT interface is bit buggy.. But there may be
> > a generic way to trigger lost QMI events based on the USB AT interface
> > notifications.
>
> Hmm, okay.
>
> >
> > What we accidentally discovered with the Maemo Droid4 modem patches was
> > that triggering a dummy QMI call on serial (muxed TS 27.010) notifications
>
> Can you clarify? QMI call on the QMI character device or on the AT port itself?
I think any QMI command on the USB QMI interface will trigger the pending
USB QMI notifications.
> > int mot_qmi_trigger_events(struct ofono_modem *modem)
> > {
> > struct motmdm_data *data = ofono_modem_get_data(modem);
> >
> > if (data->wms == NULL)
> > return -ENODEV;
> >
> > return qmi_service_send(data->wms, QMI_WMS_GET_SMSC_ADDR, NULL,
> > NULL, NULL, g_free);
> > };
> >
>
> I'm fine with this approach if the handling of this quirk is done by the
> modem driver. The modem driver can manage both QMI and AT ports. What I
> want to avoid is coupling between technologies in the atom drivers
> themselves. In other words, QMI SMS driver should not depend on anything
> related to AT commands.
OK yes doing it as needed from the modem driver makes sense.
Note that there may not even be a need for proper AT commands in this case.
It may be possible to use just ell directly, and just kick the USB QMI
interface on any output from the ttyUSB AT interface basically. Not sure
if any thing needs to be acked on the ttyUSB AT interface.
Regards,
Tony
next prev parent reply other threads:[~2024-05-21 3:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 21:49 RFC - Add AT interface to qmi device Adam Pigg
2024-05-01 21:01 ` Denis Kenzior
2024-05-19 18:26 ` Tony Lindgren
2024-05-20 18:58 ` Denis Kenzior
2024-05-21 3:11 ` Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-30 21:43 Adam Pigg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240521031105.GC5153@atomide.com \
--to=tony@atomide.com \
--cc=denkenz@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=merlijn@wizzup.org \
--cc=ofono@lists.linux.dev \
--cc=philipp@uvos.xyz \
--cc=piggz1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox