From: Denis Kenzior <denkenz@gmail.com>
To: ofono@lists.linux.dev
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH v2 07/33] udevng: Use new qrtrqmi driver for MHI and SoC modems
Date: Tue, 18 Jun 2024 15:01:49 -0500 [thread overview]
Message-ID: <20240618200231.1129282-7-denkenz@gmail.com> (raw)
In-Reply-To: <20240618200231.1129282-1-denkenz@gmail.com>
The new qrtrqmi driver only supports QRTR based devices, so drop the use
of DeviceProtocol modem attribute.
---
plugins/udevng.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/plugins/udevng.c b/plugins/udevng.c
index 0b3b9686166b..5ef0bc253562 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -278,8 +278,7 @@ static int setup_qmi_qrtr(struct modem_info *modem,
return -ENOTSUP;
}
- ofono_modem_set_driver(modem->modem, "gobi");
- ofono_modem_set_string(modem->modem, "DeviceProtocol", "qrtr");
+ ofono_modem_set_driver(modem->modem, "qrtrqmi");
return setup_qmi_netdev(modem, net);
}
@@ -309,7 +308,7 @@ static gboolean setup_gobi_qrtr_premux(struct modem_info *modem,
return TRUE;
}
-static gboolean setup_gobi_qrtr(struct modem_info *modem)
+static gboolean setup_qrtrsoc(struct modem_info *modem)
{
const struct device_info *ipa_info = NULL;
int premux_count = 0;
@@ -1798,7 +1797,7 @@ static struct {
{ "wavecom", setup_wavecom },
{ "tc65", setup_tc65 },
{ "ehs6", setup_ehs6 },
- { "gobiqrtr", setup_gobi_qrtr },
+ { "qrtrsoc", setup_qrtrsoc },
{ "mhi", setup_mhi },
{ }
};
@@ -2487,7 +2486,7 @@ static void check_net_device(struct udev_device *device)
/* Collect all rmnet devices with this iflink under a common path. */
sprintf(path, "/embedded/qrtr/%s", iflink);
- add_device(path, NULL, "gobiqrtr", NULL, NULL, MODEM_TYPE_EMBEDDED,
+ add_device(path, NULL, "qrtrsoc", NULL, NULL, MODEM_TYPE_EMBEDDED,
device, "qrtr");
}
--
2.45.0
next prev parent reply other threads:[~2024-06-18 20:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 20:01 [PATCH v2 01/33] qmi: Remove qmi_free() Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 02/33] qmi: Rename qmi_result_func_t Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 03/33] qmi: Drop unused major/minor information Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 04/33] qmi: Add qmi_qrtr_node_get_service Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 05/33] plugins: Add new qrtrqmi modem driver Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 06/33] gobi: Use correct attribute name in docs Denis Kenzior
2024-06-18 20:01 ` Denis Kenzior [this message]
2024-06-18 20:01 ` [PATCH v2 08/33] gobi: Remove qrtr support Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 09/33] udevng: Do not set DeviceProtocol Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 10/33] unit: Rename device to node Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 11/33] qmi: Rename qmi_device_new_qrtr to qmi_qrtr_node_new Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 12/33] qmi: Rename qmi_device_new_qmux to qmi_qmux_device_new Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 13/33] unit: Drop use of qmi_service_create_shared Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 14/33] qmi: qmux: Make shared service creation generic Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 15/33] qmi: Rename qmi_device_get_service_version Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 16/33] qmi: sms: Require at WMS version 1.2+ Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 17/33] qmi: Rework qmi_service_get_version Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 18/33] qmi: break up qmi_device_free into qrtr & qmux variants Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 19/33] qmi: Convert DBG statements to __debug_device Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 20/33] qmi: introduce qmi_qrtr_node_lookup Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 21/33] qmi: split qmi_device_has_service into QRTR and QMUX version Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 22/33] qmi: split qmi_device_set_debug into QRTR and QMUX versions Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 23/33] qmi: Make qmi_qrtr_node methods take struct qmi_qrtr_node Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 24/33] qmi: Move expected data format handling into gobi Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 25/33] qmi: Rename and refactor qmi_device_discover Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 26/33] qmi: Rename qmi_device_shutdown Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 27/33] qmi: Rename qmi_device_qmux to qmi_qmux_device Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 28/33] qmi: Make qmux methods operate on 'qmi_qmux_device' Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 29/33] qmi: combine service_send_data into qmi_request Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 30/33] qmi: combine qmux_client_create_data " Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 31/33] gprs: Fix memory leak Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 32/33] qmi:gprs: Don't fail on unsupported INDICATION_REGISTER Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 33/33] qmi: non-premultiplexed MHI devices Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618200231.1129282-7-denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox