From: Denis Kenzior <denkenz@gmail.com>
To: ofono@lists.linux.dev
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH v2 08/33] gobi: Remove qrtr support
Date: Tue, 18 Jun 2024 15:01:50 -0500 [thread overview]
Message-ID: <20240618200231.1129282-8-denkenz@gmail.com> (raw)
In-Reply-To: <20240618200231.1129282-1-denkenz@gmail.com>
QRTR based devices will now be managed by the qrtrqmi driver.
---
plugins/gobi.c | 38 ++++----------------------------------
1 file changed, 4 insertions(+), 34 deletions(-)
diff --git a/plugins/gobi.c b/plugins/gobi.c
index d8fd90153054..d1da5fbc366b 100644
--- a/plugins/gobi.c
+++ b/plugins/gobi.c
@@ -55,11 +55,6 @@
#define GOBI_VOICE (1 << 6)
#define GOBI_WDA (1 << 7)
-enum qmi_protocol {
- QMI_PROTOCOL_QMUX,
- QMI_PROTOCOL_QRTR,
-};
-
struct service_request {
struct qmi_service **member;
uint32_t service_type;
@@ -87,7 +82,6 @@ struct gobi_data {
char main_net_name[IFNAMSIZ];
uint32_t max_aggregation_size;
uint32_t set_powered_id;
- enum qmi_protocol protocol;
};
static void gobi_debug(const char *str, void *user_data)
@@ -101,10 +95,6 @@ static void gobi_debug(const char *str, void *user_data)
* Probe the modem. The following modem properties are expected to be set
* in order to initialize the driver properly:
*
- * DeviceProtocol
- * Can be "qrtr" or "qmux", tells the driver which QMI encapsulation protocol
- * is being used.
- *
* NetworkInterface
* The string that contains the 'main' network device. This can be
* "rmnet_ipa" on SoC systems, or "wwan0" for upstream linux systems.
@@ -122,8 +112,6 @@ static void gobi_debug(const char *str, void *user_data)
static int gobi_probe(struct ofono_modem *modem)
{
struct gobi_data *data;
- const char *value;
- enum qmi_protocol protocol;
const char *if_driver;
const char *ifname;
int ifindex;
@@ -131,15 +119,6 @@ static int gobi_probe(struct ofono_modem *modem)
DBG("%p", modem);
- value = ofono_modem_get_string(modem, "DeviceProtocol");
-
- if (l_streq0(value, "qrtr"))
- protocol = QMI_PROTOCOL_QRTR;
- else if (l_streq0(value, "qmux"))
- protocol = QMI_PROTOCOL_QMUX;
- else
- return -EPROTO;
-
if_driver = ofono_modem_get_string(modem,
"NetworkInterfaceKernelDriver");
ifname = ofono_modem_get_string(modem, "NetworkInterface");
@@ -152,7 +131,6 @@ static int gobi_probe(struct ofono_modem *modem)
return -EPROTO;
data = l_new(struct gobi_data, 1);
- data->protocol = protocol;
if (!strcmp(if_driver, "qmi_wwan_q"))
data->using_qmi_wwan_q = true;
@@ -519,19 +497,11 @@ static int gobi_enable(struct ofono_modem *modem)
DBG("%p", modem);
- switch (data->protocol) {
- case QMI_PROTOCOL_QRTR:
- data->device = qmi_device_new_qrtr();
- break;
- case QMI_PROTOCOL_QMUX:
- device = ofono_modem_get_string(modem, "Device");
- if (!device)
- return -EINVAL;
-
- data->device = qmi_device_new_qmux(device);
- break;
- }
+ device = ofono_modem_get_string(modem, "Device");
+ if (!device)
+ return -EINVAL;
+ data->device = qmi_device_new_qmux(device);
if (!data->device)
return -EIO;
--
2.45.0
next prev parent reply other threads:[~2024-06-18 20:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 20:01 [PATCH v2 01/33] qmi: Remove qmi_free() Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 02/33] qmi: Rename qmi_result_func_t Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 03/33] qmi: Drop unused major/minor information Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 04/33] qmi: Add qmi_qrtr_node_get_service Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 05/33] plugins: Add new qrtrqmi modem driver Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 06/33] gobi: Use correct attribute name in docs Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 07/33] udevng: Use new qrtrqmi driver for MHI and SoC modems Denis Kenzior
2024-06-18 20:01 ` Denis Kenzior [this message]
2024-06-18 20:01 ` [PATCH v2 09/33] udevng: Do not set DeviceProtocol Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 10/33] unit: Rename device to node Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 11/33] qmi: Rename qmi_device_new_qrtr to qmi_qrtr_node_new Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 12/33] qmi: Rename qmi_device_new_qmux to qmi_qmux_device_new Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 13/33] unit: Drop use of qmi_service_create_shared Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 14/33] qmi: qmux: Make shared service creation generic Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 15/33] qmi: Rename qmi_device_get_service_version Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 16/33] qmi: sms: Require at WMS version 1.2+ Denis Kenzior
2024-06-18 20:01 ` [PATCH v2 17/33] qmi: Rework qmi_service_get_version Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 18/33] qmi: break up qmi_device_free into qrtr & qmux variants Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 19/33] qmi: Convert DBG statements to __debug_device Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 20/33] qmi: introduce qmi_qrtr_node_lookup Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 21/33] qmi: split qmi_device_has_service into QRTR and QMUX version Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 22/33] qmi: split qmi_device_set_debug into QRTR and QMUX versions Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 23/33] qmi: Make qmi_qrtr_node methods take struct qmi_qrtr_node Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 24/33] qmi: Move expected data format handling into gobi Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 25/33] qmi: Rename and refactor qmi_device_discover Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 26/33] qmi: Rename qmi_device_shutdown Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 27/33] qmi: Rename qmi_device_qmux to qmi_qmux_device Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 28/33] qmi: Make qmux methods operate on 'qmi_qmux_device' Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 29/33] qmi: combine service_send_data into qmi_request Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 30/33] qmi: combine qmux_client_create_data " Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 31/33] gprs: Fix memory leak Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 32/33] qmi:gprs: Don't fail on unsupported INDICATION_REGISTER Denis Kenzior
2024-06-18 20:02 ` [PATCH v2 33/33] qmi: non-premultiplexed MHI devices Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618200231.1129282-8-denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox