public inbox for ofono@lists.linux.dev
 help / color / mirror / Atom feed
From: "Sicelo A. Mhlongo" <absicsz@gmail.com>
To: ofono@lists.linux.dev
Cc: "Sicelo A. Mhlongo" <absicsz@gmail.com>
Subject: [PATCH] handsfree-audio: use correct signature for GetCards
Date: Mon,  6 Jan 2025 23:53:09 +0200	[thread overview]
Message-ID: <20250106215446.14890-1-absicsz@gmail.com> (raw)

Match the signature for GetCards to the structure of the dbus container
as found in the am_get_cards function, as well as in the documentation
for the handsfree api.
---
 src/handsfree-audio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c
index 27d8331a..89b36584 100644
--- a/src/handsfree-audio.c
+++ b/src/handsfree-audio.c
@@ -813,7 +813,7 @@ static DBusMessage *am_agent_unregister(DBusConnection *conn,
 
 static const GDBusMethodTable am_methods[] = {
 	{ GDBUS_METHOD("GetCards",
-			NULL, GDBUS_ARGS({"cards", "a{oa{sv}}"}),
+			NULL, GDBUS_ARGS({"cards", "a(oa{sv})"}),
 			am_get_cards) } ,
 	{ GDBUS_METHOD("Register",
 			GDBUS_ARGS({"path", "o"}, {"codecs", "ay"}), NULL,
-- 
2.47.1


             reply	other threads:[~2025-01-06 21:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-06 21:53 Sicelo A. Mhlongo [this message]
2025-01-07 16:50 ` [PATCH] handsfree-audio: use correct signature for GetCards patchwork-bot+ofono

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250106215446.14890-1-absicsz@gmail.com \
    --to=absicsz@gmail.com \
    --cc=ofono@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox