From: Andres Salomon <dilinger@queued.net>
To: ofono@lists.linux.dev
Subject: [PATCH] callforwarding: fix missing prefixes in PropertyChanged property names
Date: Sat, 25 Apr 2026 17:19:44 -0400 [thread overview]
Message-ID: <20260425171944.18590822@5400> (raw)
A qofono test I was running hit a failure due to unexpected responses:
task-0: method call time=1777146276.985742 sender=:1.6 -> destination=org.ofono serial=23 path=/phonesim; interface=org.ofono.CallForwarding; member=SetProperty
task-0: string "VoiceUnconditional"
task-0: variant string "12345678"
task-0: method return time=1777146276.991119 sender=:1.1 -> destination=:1.6 serial=159 reply_serial=23
task-0: signal time=1777146276.991146 sender=:1.1 -> destination=(null destination) serial=160 path=/phonesim; interface=org.ofono.CallForwarding; member=PropertyChanged
task-0: string "VoiceUnconditional"
task-0: variant string "12345678"
task-0: signal time=1777146276.991165 sender=:1.1 -> destination=(null destination) serial=161 path=/phonesim; interface=org.ofono.CallForwarding; member=PropertyChanged
task-0: string "Busy"
task-0: variant string ""
task-0: signal time=1777146276.991181 sender=:1.1 -> destination=(null destination) serial=162 path=/phonesim; interface=org.ofono.CallForwarding; member=PropertyChanged
task-0: string "NoReply"
task-0: variant string ""
task-0: signal time=1777146276.991196 sender=:1.1 -> destination=(null destination) serial=163 path=/phonesim; interface=org.ofono.CallForwarding; member=PropertyChanged
task-0: string "NotReachable"
task-0: variant string ""
task-0: signal time=1777146276.991212 sender=:1.1 -> destination=(null destination) serial=164 path=/phonesim; interface=org.ofono.CallForwarding; member=PropertyChanged
task-0: string "ForwardingFlagOnSim"
task-0: variant boolean true
Other places in the code and call-forwarding-api.txt document that those
property names should have a class prefix like "VoiceNoReply", instead
of just "NoReply". This fixes the lack of prefix.
---
src/call-forwarding.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/call-forwarding.c b/src/call-forwarding.c
index 9aca1f03..12bc463f 100644
--- a/src/call-forwarding.c
+++ b/src/call-forwarding.c
@@ -395,9 +395,13 @@ static void set_new_cond_list(struct ofono_call_forwarding *cf,
number = phone_number_to_string(
&lc->phone_number);
+ snprintf(attr, sizeof(attr), "%s%s",
+ bearer_class_to_string(BEARER_CLASS_VOICE),
+ cf_type_lut[i]);
+
ofono_dbus_signal_property_changed(conn, path,
OFONO_CALL_FORWARDING_INTERFACE,
- cf_type_lut[i],
+ attr,
DBUS_TYPE_STRING, &number);
}
--
2.53.0
reply other threads:[~2026-04-25 21:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260425171944.18590822@5400 \
--to=dilinger@queued.net \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox