Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: SV: Handling empty row from AT command
Date: Wed, 20 Jun 2018 08:30:00 -0500	[thread overview]
Message-ID: <3f286d85-c72a-e4e2-c203-3524744595f5@gmail.com> (raw)
In-Reply-To: <AM5PR1001MB1171B048483CE3C97BE6584896770@AM5PR1001MB1171.EURPRD10.PROD.OUTLOOK.COM>

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

Hi Mattias,

On 06/20/2018 08:24 AM, Mattias Månsson wrote:
> It seems we already use that parser though:
> 
> syntax = g_at_syntax_new_gsm_permissive();
> chat = g_at_chat_new(channel, syntax);
> 

Not sure then.  Permissive should be taking care of the issue you 
describe, e.g it skips any empty lines:

                 case GSM_PERMISSIVE_STATE_IDLE:
                         if (byte == '\r' || byte == '\n')
                                 /* ignore */;

Maybe there's something more subtle going on?  Are there stray 
whitespace characters or something else in the spurious response?  You 
would have to trace why the permissive syntax fails and either fix it or 
design your own.

Regards,
-Denis

  reply	other threads:[~2018-06-20 13:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20  7:34 Handling empty row from AT command Mattias =?unknown-8bit?q?M=C3=A5nsson?=
2018-06-20 13:20 ` Denis Kenzior
2018-06-20 13:24   ` SV: " Mattias =?unknown-8bit?q?M=C3=A5nsson?=
2018-06-20 13:30     ` Denis Kenzior [this message]
2018-06-20 13:33       ` SV: " Mattias =?unknown-8bit?q?M=C3=A5nsson?=
2018-06-20 13:58         ` Mattias =?unknown-8bit?q?M=C3=A5nsson?=
2018-06-20 14:28           ` Denis Kenzior
2018-06-20 14:30             ` SV: " Mattias =?unknown-8bit?q?M=C3=A5nsson?=

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f286d85-c72a-e4e2-c203-3524744595f5@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox