From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/2] plugins: Add Gemalto plugin for Cinterion P-family
Date: Mon, 16 Jan 2017 21:50:43 -0600 [thread overview]
Message-ID: <4555dafb-46ca-1921-4e27-28c167a519b6@gmail.com> (raw)
In-Reply-To: <1484557673-15666-1-git-send-email-vincent.cesson@smile.fr>
[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]
Hi Vincent,
On 01/16/2017 03:07 AM, Vincent Cesson wrote:
> Actual cinterion plugin is not compliant with newer Gemalto modems.
> Gemalto plugin is based on cinterion with a custom struct to handle the
> interfaces Application and Modem.
> ---
> Makefile.am | 3 +
> plugins/gemalto.c | 264 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 267 insertions(+)
> create mode 100644 plugins/gemalto.c
>
When applied, I got the following compile error:
plugins/gemalto.c: In function ‘gemalto_pre_sim’:
plugins/gemalto.c:197:2: error: implicit declaration of function
‘ofono_location_reporting_create’ [-Werror=implicit-function-declaration]
ofono_location_reporting_create(modem, 0, "gemaltomodem", data->app);
^
I'm guessing you have some location reporting patches forthcoming.
Anyway, I took out the offending line (please add it in your patch
series dealing with location reporting) and pushed upstream.
Regards,
-Denis
next prev parent reply other threads:[~2017-01-17 3:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 17:06 [RFC 0/3] Add Gemalto Cinterion P-Family support Vincent Cesson
2017-01-12 17:06 ` [RFC 1/3] plugins: Add Gemalto plugin for Cinterion P-family Vincent Cesson
2017-01-13 22:30 ` Denis Kenzior
2017-01-16 9:07 ` [PATCH 1/2] " Vincent Cesson
2017-01-16 9:07 ` [PATCH 2/2] udevng: Add Gemalto P-family detection Vincent Cesson
2017-01-17 3:52 ` Denis Kenzior
2017-01-17 3:50 ` Denis Kenzior [this message]
2017-01-12 17:06 ` [RFC 2/3] " Vincent Cesson
2017-01-13 22:31 ` Denis Kenzior
2017-01-12 17:06 ` [RFC 3/3] build: Add Gemalto plugin in Makefile Vincent Cesson
2017-01-13 22:32 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4555dafb-46ca-1921-4e27-28c167a519b6@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox