Open Source Telephony
 help / color / mirror / Atom feed
From: Marko Saukko <marko.saukko@gmail.com>
To: ofono@ofono.org
Subject: [PATCH] Fix g_isi_client_destroy segfault
Date: Thu, 09 Jul 2009 15:37:48 +0300	[thread overview]
Message-ID: <4A55E49C.6020006@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

If null pointer is given to g_isi_client_destroy it segfaults. Currently
this is happening when signal 15 is sent to ofonod.

---

diff --git a/gisi/client.c b/gisi/client.c
index b12dc85..a12640d 100644
--- a/gisi/client.c
+++ b/gisi/client.c
@@ -143,6 +143,8 @@ void g_isi_client_destroy(GIsiClient *client)
 {
        unsigned id;

+       if (!client)
+               return;
        g_source_remove(client->source);
        for (id = 0; id < 256; id++)
                if (client->timeout[id] > 0)

             reply	other threads:[~2009-07-09 12:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09 12:37 Marko Saukko [this message]
2009-07-09 13:19 ` [PATCH] Fix g_isi_client_destroy segfault Aki Niemi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A55E49C.6020006@gmail.com \
    --to=marko.saukko@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox