Open Source Telephony
 help / color / mirror / Atom feed
From: Zhenhua Zhang <zhenhua.zhang@intel.com>
To: ofono@ofono.org
Subject: Re: [PATCH 7/7] Add g_at_server_register to register callback
Date: Thu, 04 Mar 2010 09:41:54 +0800	[thread overview]
Message-ID: <4B8F0FE2.2050003@intel.com> (raw)
In-Reply-To: <201003031328.16832.denkenz@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

Hi Denis,

On 03/04/2010 03:28 AM, Denis Kenzior wrote:
> Hi Zhenhua,
>
>> ---
>>   gatchat/gatserver.c |   47
> +++++++++++++++++++++++++++++++++++++++++++++++
>>   gatchat/gatserver.h |    6 ++++++
>>   2 files changed, 53 insertions(+), 0 deletions(-)
>>
>> +guint g_at_server_register(GAtServer *server, const char *prefix,
>> +					GAtServerCommandType type,
>> +					GAtServerNotifyFunc notify,
>> +					gpointer user_data,
>> +					GDestroyNotify destroy_notify);
>
> Return a gboolean here.  And where's my unregister function?

OK. g_at_server_unregister will be added next time. :-)

>> +
>>   #ifdef __cplusplus
>>   }
>>   #endif
>>
>
> Regards,
> -Denis
> _______________________________________________
> ofono mailing list
> ofono(a)ofono.org
> http://lists.ofono.org/listinfo/ofono
>


  reply	other threads:[~2010-03-04  1:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-03 14:56 [PATCH 1/7] Remove old server_parse_line Zhenhua Zhang
2010-03-03 14:56 ` [PATCH 2/7] Add framework of server parser Zhenhua Zhang
2010-03-03 14:56   ` [PATCH 3/7] Add basic command parsing Zhenhua Zhang
2010-03-03 14:56     ` [PATCH 4/7] Add extended " Zhenhua Zhang
2010-03-03 14:56       ` [PATCH 5/7] Add server at command data structure Zhenhua Zhang
2010-03-03 14:56         ` [PATCH 6/7] Add notify at command callback Zhenhua Zhang
2010-03-03 14:56           ` [PATCH 7/7] Add g_at_server_register to register callback Zhenhua Zhang
2010-03-03 19:28             ` Denis Kenzior
2010-03-04  1:41               ` Zhenhua Zhang [this message]
2010-03-03 19:23         ` [PATCH 5/7] Add server at command data structure Denis Kenzior
2010-03-04  1:40           ` Zhenhua Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B8F0FE2.2050003@intel.com \
    --to=zhenhua.zhang@intel.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox