From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] gathdlc: Unset disconnect function in unref
Date: Tue, 06 Jul 2010 11:28:26 -0500 [thread overview]
Message-ID: <4C3359AA.3000500@gmail.com> (raw)
In-Reply-To: <1278410258-3077-2-git-send-email-zhenhua.zhang@intel.com>
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
Hi Zhenhua,
> @@ -278,6 +278,7 @@ void g_at_hdlc_unref(GAtHDLC *hdlc)
> hdlc->record_fd = -1;
> }
>
> + g_at_io_set_disconnect_function(hdlc->io, NULL, NULL);
Since GAtHDLC does not set the disconnect function, this really belongs
in GAtPPP.
> g_at_io_unref(hdlc->io);
> hdlc->io = NULL;
>
However, I really question why this patch is necessary. The only way
the disconnect function is not reset today is if the GAtIO is refed and
g_at_chat_resume is not called.
We do call g_at_io_set_disconnect function in g_at_chat_resume.
Regards,
-Denis
next prev parent reply other threads:[~2010-07-06 16:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 9:57 [PATCH 1/2] gatppp: Check ppp instance before unref it Zhenhua Zhang
2010-07-06 9:57 ` [PATCH 2/2] gathdlc: Unset disconnect function in unref Zhenhua Zhang
2010-07-06 10:03 ` Zhang, Zhenhua
2010-07-06 16:45 ` Denis Kenzior
2010-07-06 16:28 ` Denis Kenzior [this message]
2010-07-07 1:32 ` Zhang, Zhenhua
2010-07-06 12:48 ` [PATCH 1/2] gatppp: Check ppp instance before unref it Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3359AA.3000500@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox