From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/9] stkutil: display text attributes as html
Date: Thu, 15 Jul 2010 15:32:11 -0500 [thread overview]
Message-ID: <4C3F704B.3010502@gmail.com> (raw)
In-Reply-To: <AANLkTikNE6jXa6Qhu33llLQGsUMnAGQPnchN_nBflHpB@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
Hi Andrew,
> One idea to handle this was for the text_to_html function to take a
> language parameter (for now it could just hardcode English) and decide
> the default alignment based on it. Then default alignment (bits 0:3
> == 3) would be treated same as left (or right).
Yes that is another approach, however I think that this might be moot
anyway. At least on my Sony Ericsson T610 the EMS composer defaults to
alignment 'Auto' (No Alignment in the protocol) and only adds
Left/Right/Center alignment when the user tells it to.
>
> This assumes the test is correct afterall, because it's not clear from 23 040.
>
I'm fairly sure the current test case is synthetic, so might not reflect
how EMS messages are created in the real world.
I added another test case to test-sms with a test message composed by my
T610. That is the better test case to focus on.
Regards,
-Denis
next prev parent reply other threads:[~2010-07-15 20:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 13:45 [PATCH 0/9] html text attribute patches Kristen Carlson Accardi
2010-07-02 13:46 ` [PATCH 1/9] stkutil: display text attributes as html Kristen Carlson Accardi
2010-07-08 22:49 ` Denis Kenzior
2010-07-09 21:58 ` Kristen Carlson Accardi
2010-07-09 22:13 ` Denis Kenzior
2010-07-09 22:26 ` Kristen Carlson Accardi
2010-07-13 15:00 ` Denis Kenzior
2010-07-15 20:17 ` andrzej zaborowski
2010-07-15 20:32 ` Denis Kenzior [this message]
2010-07-02 13:46 ` [PATCH 2/9] test-stkutil: add unit test for html text attributes Kristen Carlson Accardi
2010-07-02 13:46 ` [PATCH 3/9] test-stkutil: add html attribute test for Display Text tests Kristen Carlson Accardi
2010-07-02 13:46 ` [PATCH 4/9] test-stkutil: add html attribute tests for get_inkey_test Kristen Carlson Accardi
2010-07-02 13:46 ` [PATCH 5/9] test-stkutil: add html attribute tests for get_input_test Kristen Carlson Accardi
2010-07-02 13:46 ` [PATCH 6/9] test-stkutil: add html attribute tests for play_tone_test Kristen Carlson Accardi
2010-07-02 13:46 ` [PATCH 7/9] test-stkutil: add html attribute test for setup_menu_test Kristen Carlson Accardi
2010-07-02 13:46 ` [PATCH 8/9] test-stkutil: add html attribute test for select_item_test Kristen Carlson Accardi
2010-07-02 13:46 ` [PATCH 9/9] test-stkutil: add html attribute tests for setup idle mode tests Kristen Carlson Accardi
-- strict thread matches above, loose matches on Subject: below --
2010-07-13 12:40 [PATCH 0/9] html text attribute patches Kristen Carlson Accardi
2010-07-13 12:40 ` [PATCH 1/9] stkutil: display text attributes as html Kristen Carlson Accardi
2010-07-13 20:38 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3F704B.3010502@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox